tests: replace "cp -r" with "cp -R" The POSIX documentation about "cp" [1] says: .... RATIONALE .... Earlier versions of this standard included support for the -r option to copy file hierarchies. The -r option is historical practice on BSD and BSD-derived systems. This option is no longer specified by POSIX.1-2008 but may be present in some implementations. The -R option was added as a close synonym to the -r option, selected for consistency with all other options in this volume of POSIX.1-2008 that do recursive directory descent. The difference between -R and the removed -r option is in the treatment by cp of file types other than regular and directory. It was implementation-defined how the - option treated special files to allow both historical implementations and those that chose to support -r with the same abilities as -R defined by this volume of POSIX.1-2008. The original -r flag, for historic reasons, did not handle special files any differently from regular files, but always read the file and copied its contents. This had obvious problems in the presence of special file types; for example, character devices, FIFOs, and sockets. .... .... Issue 6 The -r option is marked obsolescent. .... Issue 7 .... The obsolescent -r option is removed. .... (No "Issue 8" yet) Therefore it's clear that "cp -R" is strictly better than "cp -r". The issue was discovered when running tests on OS X after 0d87b1caed92. [1]: pubs.opengroup.org/onlinepubs/9699919799/utilities/cp.html

     1

Source bundle was generated with the following script:

     2

     3

# hg init

     4

# echo a > a

     5

# ln -s a l

     6

# hg ci -Ama -d'0 0'

     7

# mkdir b

     8

# echo a > b/a

     9

# chmod +x b/a

    10

# hg ci -Amb -d'1 0'

    11

    12

  $ hg init

    13

  $ hg -q pull "$TESTDIR/bundles/test-manifest.hg"

    14

    15

The next call is expected to return nothing:

    16

    17

  $ hg manifest

    18

    19

  $ hg co

    20

  3 files updated, 0 files merged, 0 files removed, 0 files unresolved

    21

    22

  $ hg manifest

    23

  a

    24

  b/a

    25

  l

    26

    27

  $ hg files -vr .

    28

           2   a

    29

           2 x b/a (glob)

    30

           1 l l

    31

  $ hg files -r . -X b

    32

  a

    33

  l

    34

    35

  $ hg manifest -v

    36

  644   a

    37

  755 * b/a

    38

  644 @ l

    39

    40

  $ hg manifest --debug

    41

  b789fdd96dc2f3bd229c1dd8eedf0fc60e2b68e3 644   a

    42

  b789fdd96dc2f3bd229c1dd8eedf0fc60e2b68e3 755 * b/a

    43

  047b75c6d7a3ef6a2243bd0e99f94f6ea6683597 644 @ l

    44

    45

  $ hg manifest -r 0

    46

  a

    47

  l

    48

    49

  $ hg manifest -r 1

    50

  a

    51

  b/a

    52

  l

    53

    54

  $ hg manifest -r tip

    55

  a

    56

  b/a

    57

  l

    58

    59

  $ hg manifest tip

    60

  a

    61

  b/a

    62

  l

    63

    64

  $ hg manifest --all

    65

  a

    66

  b/a

    67

  l

    68

    69

The next two calls are expected to abort:

    70

    71

  $ hg manifest -r 2

    72

  abort: unknown revision '2'!

    73

  [255]

    74

    75

  $ hg manifest -r tip tip

    76

  abort: please specify just one revision

    77

  [255]