tests: replace "cp -r" with "cp -R" The POSIX documentation about "cp" [1] says: .... RATIONALE .... Earlier versions of this standard included support for the -r option to copy file hierarchies. The -r option is historical practice on BSD and BSD-derived systems. This option is no longer specified by POSIX.1-2008 but may be present in some implementations. The -R option was added as a close synonym to the -r option, selected for consistency with all other options in this volume of POSIX.1-2008 that do recursive directory descent. The difference between -R and the removed -r option is in the treatment by cp of file types other than regular and directory. It was implementation-defined how the - option treated special files to allow both historical implementations and those that chose to support -r with the same abilities as -R defined by this volume of POSIX.1-2008. The original -r flag, for historic reasons, did not handle special files any differently from regular files, but always read the file and copied its contents. This had obvious problems in the presence of special file types; for example, character devices, FIFOs, and sockets. .... .... Issue 6 The -r option is marked obsolescent. .... Issue 7 .... The obsolescent -r option is removed. .... (No "Issue 8" yet) Therefore it's clear that "cp -R" is strictly better than "cp -r". The issue was discovered when running tests on OS X after 0d87b1caed92. [1]: pubs.opengroup.org/onlinepubs/9699919799/utilities/cp.html

     1

     2

  $ cat > unix2mac.py <<EOF

     3

  > import sys

     4

  > 

     5

  > for path in sys.argv[1:]:

     6

  >     data = file(path, 'rb').read()

     7

  >     data = data.replace('\n', '\r')

     8

  >     file(path, 'wb').write(data)

     9

  > EOF

    10

  $ cat > print.py <<EOF

    11

  > import sys

    12

  > print(sys.stdin.read().replace('\n', '<LF>').replace('\r', '<CR>').replace('\0', '<NUL>'))

    13

  > EOF

    14

  $ hg init

    15

  $ echo '[hooks]' >> .hg/hgrc

    16

  $ echo 'pretxncommit.cr = python:hgext.win32text.forbidcr' >> .hg/hgrc

    17

  $ echo 'pretxnchangegroup.cr = python:hgext.win32text.forbidcr' >> .hg/hgrc

    18

  $ cat .hg/hgrc

    19

  [hooks]

    20

  pretxncommit.cr = python:hgext.win32text.forbidcr

    21

  pretxnchangegroup.cr = python:hgext.win32text.forbidcr

    22

    23

  $ echo hello > f

    24

  $ hg add f

    25

  $ hg ci -m 1

    26

    27

  $ python unix2mac.py f

    28

  $ hg ci -m 2

    29

  attempt to commit or push text file(s) using CR line endings

    30

  in dea860dc51ec: f

    31

  transaction abort!

    32

  rollback completed

    33

  abort: pretxncommit.cr hook failed

    34

  [255]

    35

  $ hg cat f | python print.py

    36

  hello<LF>

    37

  $ cat f | python print.py

    38

  hello<CR>