tests: replace "cp -r" with "cp -R" The POSIX documentation about "cp" [1] says: .... RATIONALE .... Earlier versions of this standard included support for the -r option to copy file hierarchies. The -r option is historical practice on BSD and BSD-derived systems. This option is no longer specified by POSIX.1-2008 but may be present in some implementations. The -R option was added as a close synonym to the -r option, selected for consistency with all other options in this volume of POSIX.1-2008 that do recursive directory descent. The difference between -R and the removed -r option is in the treatment by cp of file types other than regular and directory. It was implementation-defined how the - option treated special files to allow both historical implementations and those that chose to support -r with the same abilities as -R defined by this volume of POSIX.1-2008. The original -r flag, for historic reasons, did not handle special files any differently from regular files, but always read the file and copied its contents. This had obvious problems in the presence of special file types; for example, character devices, FIFOs, and sockets. .... .... Issue 6 The -r option is marked obsolescent. .... Issue 7 .... The obsolescent -r option is removed. .... (No "Issue 8" yet) Therefore it's clear that "cp -R" is strictly better than "cp -r". The issue was discovered when running tests on OS X after 0d87b1caed92. [1]: pubs.opengroup.org/onlinepubs/9699919799/utilities/cp.html

     1

Test if logtoprocess correctly captures command-related log calls.

     2

     3

  $ hg init

     4

  $ cat > $TESTTMP/foocommand.py << EOF

     5

  > from mercurial import cmdutil

     6

  > from time import sleep

     7

  > cmdtable = {}

     8

  > command = cmdutil.command(cmdtable)

     9

  > @command('foo', [])

    10

  > def foo(ui, repo):

    11

  >     ui.log('foo', 'a message: %(bar)s\n', bar='spam')

    12

  > EOF

    13

  $ cat >> $HGRCPATH << EOF

    14

  > [extensions]

    15

  > logtoprocess=

    16

  > foocommand=$TESTTMP/foocommand.py

    17

  > [logtoprocess]

    18

  > command=echo 'logtoprocess command output:';

    19

  >     echo "\$EVENT";

    20

  >     echo "\$MSG1";

    21

  >     echo "\$MSG2"

    22

  > commandfinish=echo 'logtoprocess commandfinish output:';

    23

  >     echo "\$EVENT";

    24

  >     echo "\$MSG1";

    25

  >     echo "\$MSG2";

    26

  >     echo "\$MSG3"

    27

  > foo=echo 'logtoprocess foo output:';

    28

  >     echo "\$EVENT";

    29

  >     echo "\$MSG1";

    30

  >     echo "\$OPT_BAR"

    31

  > EOF

    32

    33

Running a command triggers both a ui.log('command') and a

    34

ui.log('commandfinish') call. The foo command also uses ui.log.

    35

    36

Use head to ensure we wait for all lines to be produced, and sort to avoid

    37

ordering issues between the various processes we spawn:

    38

  $ hg foo | head -n 17 | sort

    39

    40

    41

    42

  0

    43

  a message: spam

    44

  command

    45

  commandfinish

    46

  foo

    47

  foo

    48

  foo

    49

  foo

    50

  foo exited 0 after * seconds (glob)

    51

  logtoprocess command output:

    52

  logtoprocess commandfinish output:

    53

  logtoprocess foo output:

    54

  spam