tests: replace "cp -r" with "cp -R" The POSIX documentation about "cp" [1] says: .... RATIONALE .... Earlier versions of this standard included support for the -r option to copy file hierarchies. The -r option is historical practice on BSD and BSD-derived systems. This option is no longer specified by POSIX.1-2008 but may be present in some implementations. The -R option was added as a close synonym to the -r option, selected for consistency with all other options in this volume of POSIX.1-2008 that do recursive directory descent. The difference between -R and the removed -r option is in the treatment by cp of file types other than regular and directory. It was implementation-defined how the - option treated special files to allow both historical implementations and those that chose to support -r with the same abilities as -R defined by this volume of POSIX.1-2008. The original -r flag, for historic reasons, did not handle special files any differently from regular files, but always read the file and copied its contents. This had obvious problems in the presence of special file types; for example, character devices, FIFOs, and sockets. .... .... Issue 6 The -r option is marked obsolescent. .... Issue 7 .... The obsolescent -r option is removed. .... (No "Issue 8" yet) Therefore it's clear that "cp -R" is strictly better than "cp -r". The issue was discovered when running tests on OS X after 0d87b1caed92. [1]: pubs.opengroup.org/onlinepubs/9699919799/utilities/cp.html

     1

from __future__ import absolute_import, print_function

     2

     3

from mercurial import extensions

     4

     5

def genwrapper(x):

     6

    def f(orig, *args, **kwds):

     7

        return [x] + orig(*args, **kwds)

     8

    f.x = x

     9

    return f

    10

    11

def getid(wrapper):

    12

    return getattr(wrapper, 'x', '-')

    13

    14

wrappers = [genwrapper(i) for i in range(5)]

    15

    16

class dummyclass(object):

    17

    def getstack(self):

    18

        return ['orig']

    19

    20

dummy = dummyclass()

    21

    22

def batchwrap(wrappers):

    23

    for w in wrappers:

    24

        extensions.wrapfunction(dummy, 'getstack', w)

    25

        print('wrap %d: %s' % (getid(w), dummy.getstack()))

    26

    27

def batchunwrap(wrappers):

    28

    for w in wrappers:

    29

        result = None

    30

        try:

    31

            result = extensions.unwrapfunction(dummy, 'getstack', w)

    32

            msg = str(dummy.getstack())

    33

        except (ValueError, IndexError) as e:

    34

            msg = e.__class__.__name__

    35

        print('unwrap %s: %s: %s' % (getid(w), getid(result), msg))

    36

    37

batchwrap(wrappers + [wrappers[0]])

    38

batchunwrap([(wrappers[i] if i >= 0 else None)

    39

             for i in [3, None, 0, 4, 0, 2, 1, None]])