tests: replace "cp -r" with "cp -R" The POSIX documentation about "cp" [1] says: .... RATIONALE .... Earlier versions of this standard included support for the -r option to copy file hierarchies. The -r option is historical practice on BSD and BSD-derived systems. This option is no longer specified by POSIX.1-2008 but may be present in some implementations. The -R option was added as a close synonym to the -r option, selected for consistency with all other options in this volume of POSIX.1-2008 that do recursive directory descent. The difference between -R and the removed -r option is in the treatment by cp of file types other than regular and directory. It was implementation-defined how the - option treated special files to allow both historical implementations and those that chose to support -r with the same abilities as -R defined by this volume of POSIX.1-2008. The original -r flag, for historic reasons, did not handle special files any differently from regular files, but always read the file and copied its contents. This had obvious problems in the presence of special file types; for example, character devices, FIFOs, and sockets. .... .... Issue 6 The -r option is marked obsolescent. .... Issue 7 .... The obsolescent -r option is removed. .... (No "Issue 8" yet) Therefore it's clear that "cp -R" is strictly better than "cp -r". The issue was discovered when running tests on OS X after 0d87b1caed92. [1]: pubs.opengroup.org/onlinepubs/9699919799/utilities/cp.html

     1

#require test-repo slow docker

     2

     3

  $ . "$TESTDIR/helpers-testrepo.sh"

     4

     5

Ensure debuild doesn't run the testsuite, as that could get silly.

     6

  $ DEB_BUILD_OPTIONS=nocheck

     7

  $ export DEB_BUILD_OPTIONS

     8

  $ OUTPUTDIR=`pwd`

     9

  $ export OUTPUTDIR

    10

    11

  $ cd "$TESTDIR"/..

    12

  $ make docker-debian-jessie > $OUTPUTDIR/build.log 2>&1

    13

  $ cd $OUTPUTDIR

    14

  $ ls *.deb

    15

  mercurial-common_*.deb (glob)

    16

  mercurial_*.deb (glob)

    17

    18

We check debian package contents with portable tools so that when

    19

we're on non-debian machines we can still test the packages that are

    20

built using docker.

    21

    22

main deb should have .so but no .py

    23

  $ ar x mercurial_*.deb

    24

  $ tar tf data.tar* | egrep '(localrepo|parsers)'

    25

  ./usr/lib/python2.7/dist-packages/mercurial/parsers*.so (glob)

    26

mercurial-common should have .py but no .so or .pyc

    27

  $ ar x mercurial-common_*.deb

    28

  $ tar tf data.tar* | egrep '(localrepo|parsers)'

    29

  ./usr/lib/python2.7/dist-packages/mercurial/pure/parsers.py

    30

  ./usr/lib/python2.7/dist-packages/mercurial/localrepo.py