tests: replace "cp -r" with "cp -R" The POSIX documentation about "cp" [1] says: .... RATIONALE .... Earlier versions of this standard included support for the -r option to copy file hierarchies. The -r option is historical practice on BSD and BSD-derived systems. This option is no longer specified by POSIX.1-2008 but may be present in some implementations. The -R option was added as a close synonym to the -r option, selected for consistency with all other options in this volume of POSIX.1-2008 that do recursive directory descent. The difference between -R and the removed -r option is in the treatment by cp of file types other than regular and directory. It was implementation-defined how the - option treated special files to allow both historical implementations and those that chose to support -r with the same abilities as -R defined by this volume of POSIX.1-2008. The original -r flag, for historic reasons, did not handle special files any differently from regular files, but always read the file and copied its contents. This had obvious problems in the presence of special file types; for example, character devices, FIFOs, and sockets. .... .... Issue 6 The -r option is marked obsolescent. .... Issue 7 .... The obsolescent -r option is removed. .... (No "Issue 8" yet) Therefore it's clear that "cp -R" is strictly better than "cp -r". The issue was discovered when running tests on OS X after 0d87b1caed92. [1]: pubs.opengroup.org/onlinepubs/9699919799/utilities/cp.html

     1

  $ hg init

     2

     3

  $ mkdir alpha

     4

  $ touch alpha/one

     5

  $ mkdir beta

     6

  $ touch beta/two

     7

     8

  $ hg add alpha/one beta/two

     9

  $ hg ci -m "start"

    10

    11

  $ echo 1 > alpha/one

    12

  $ echo 2 > beta/two

    13

    14

everything

    15

    16

  $ hg diff --nodates

    17

  diff -r 7d5ef1aea329 alpha/one

    18

  --- a/alpha/one

    19

  +++ b/alpha/one

    20

  @@ -0,0 +1,1 @@

    21

  +1

    22

  diff -r 7d5ef1aea329 beta/two

    23

  --- a/beta/two

    24

  +++ b/beta/two

    25

  @@ -0,0 +1,1 @@

    26

  +2

    27

    28

beta only

    29

    30

  $ hg diff --nodates beta

    31

  diff -r 7d5ef1aea329 beta/two

    32

  --- a/beta/two

    33

  +++ b/beta/two

    34

  @@ -0,0 +1,1 @@

    35

  +2

    36

    37

inside beta

    38

    39

  $ cd beta

    40

  $ hg diff --nodates .

    41

  diff -r 7d5ef1aea329 beta/two

    42

  --- a/beta/two

    43

  +++ b/beta/two

    44

  @@ -0,0 +1,1 @@

    45

  +2

    46

    47

relative to beta

    48

    49

  $ cd ..

    50

  $ hg diff --nodates --root beta

    51

  diff -r 7d5ef1aea329 two

    52

  --- a/two

    53

  +++ b/two

    54

  @@ -0,0 +1,1 @@

    55

  +2

    56

    57

inside beta

    58

    59

  $ cd beta

    60

  $ hg diff --nodates --root .

    61

  diff -r 7d5ef1aea329 two

    62

  --- a/two

    63

  +++ b/two

    64

  @@ -0,0 +1,1 @@

    65

  +2

    66

    67

  $ cd ..