tests: replace "cp -r" with "cp -R" The POSIX documentation about "cp" [1] says: .... RATIONALE .... Earlier versions of this standard included support for the -r option to copy file hierarchies. The -r option is historical practice on BSD and BSD-derived systems. This option is no longer specified by POSIX.1-2008 but may be present in some implementations. The -R option was added as a close synonym to the -r option, selected for consistency with all other options in this volume of POSIX.1-2008 that do recursive directory descent. The difference between -R and the removed -r option is in the treatment by cp of file types other than regular and directory. It was implementation-defined how the - option treated special files to allow both historical implementations and those that chose to support -r with the same abilities as -R defined by this volume of POSIX.1-2008. The original -r flag, for historic reasons, did not handle special files any differently from regular files, but always read the file and copied its contents. This had obvious problems in the presence of special file types; for example, character devices, FIFOs, and sockets. .... .... Issue 6 The -r option is marked obsolescent. .... Issue 7 .... The obsolescent -r option is removed. .... (No "Issue 8" yet) Therefore it's clear that "cp -R" is strictly better than "cp -r". The issue was discovered when running tests on OS X after 0d87b1caed92. [1]: pubs.opengroup.org/onlinepubs/9699919799/utilities/cp.html

     1

  $ for i in aaa zzz; do

     2

  >     hg init t

     3

  >     cd t

     4

  > 

     5

  >     echo

     6

  >     echo "-- With $i"

     7

  > 

     8

  >     touch file

     9

  >     hg add file

    10

  >     hg ci -m "Add"

    11

  > 

    12

  >     hg cp file $i

    13

  >     hg ci -m "a -> $i"

    14

  > 

    15

  >     hg cp $i other-file

    16

  >     echo "different" >> $i

    17

  >     hg ci -m "$i -> other-file"

    18

  > 

    19

  >     hg cp other-file somename

    20

  > 

    21

  >     echo "Status":

    22

  >     hg st -C

    23

  >     echo

    24

  >     echo "Diff:"

    25

  >     hg diff -g

    26

  > 

    27

  >     cd ..

    28

  >     rm -rf t

    29

  > done

    30

    31

  -- With aaa

    32

  Status:

    33

  A somename

    34

    other-file

    35

    36

  Diff:

    37

  diff --git a/other-file b/somename

    38

  copy from other-file

    39

  copy to somename

    40

    41

  -- With zzz

    42

  Status:

    43

  A somename

    44

    other-file

    45

    46

  Diff:

    47

  diff --git a/other-file b/somename

    48

  copy from other-file

    49

  copy to somename

    50

    51