tests: replace "cp -r" with "cp -R" The POSIX documentation about "cp" [1] says: .... RATIONALE .... Earlier versions of this standard included support for the -r option to copy file hierarchies. The -r option is historical practice on BSD and BSD-derived systems. This option is no longer specified by POSIX.1-2008 but may be present in some implementations. The -R option was added as a close synonym to the -r option, selected for consistency with all other options in this volume of POSIX.1-2008 that do recursive directory descent. The difference between -R and the removed -r option is in the treatment by cp of file types other than regular and directory. It was implementation-defined how the - option treated special files to allow both historical implementations and those that chose to support -r with the same abilities as -R defined by this volume of POSIX.1-2008. The original -r flag, for historic reasons, did not handle special files any differently from regular files, but always read the file and copied its contents. This had obvious problems in the presence of special file types; for example, character devices, FIFOs, and sockets. .... .... Issue 6 The -r option is marked obsolescent. .... Issue 7 .... The obsolescent -r option is removed. .... (No "Issue 8" yet) Therefore it's clear that "cp -R" is strictly better than "cp -r". The issue was discovered when running tests on OS X after 0d87b1caed92. [1]: pubs.opengroup.org/onlinepubs/9699919799/utilities/cp.html

     1

#require bzr

     2

     3

  $ . "$TESTDIR/bzr-definitions"

     4

  $ cat > ghostcreator.py <<EOF

     5

  > import sys

     6

  > from bzrlib import workingtree

     7

  > wt = workingtree.WorkingTree.open('.')

     8

  > 

     9

  > message, ghostrev = sys.argv[1:]

    10

  > wt.set_parent_ids(wt.get_parent_ids() + [ghostrev])

    11

  > wt.commit(message)

    12

  > EOF

    13

    14

ghost revisions

    15

    16

  $ mkdir test-ghost-revisions

    17

  $ cd test-ghost-revisions

    18

  $ bzr init -q source

    19

  $ cd source

    20

  $ echo content > somefile

    21

  $ bzr add -q somefile

    22

  $ bzr commit -q -m 'Initial layout setup'

    23

  $ echo morecontent >> somefile

    24

  $ python ../../ghostcreator.py 'Commit with ghost revision' ghostrev

    25

  $ cd ..

    26

  $ hg convert source source-hg

    27

  initializing destination source-hg repository

    28

  scanning source...

    29

  sorting...

    30

  converting...

    31

  1 Initial layout setup

    32

  0 Commit with ghost revision

    33

  $ glog -R source-hg

    34

  o  1@source "Commit with ghost revision" files: somefile

    35

  |

    36

  o  0@source "Initial layout setup" files: somefile

    37

    38

    39

  $ cd ..