nodemap: gate the feature behind a new requirement Now that the feature is working smoothly, a question was still open, should we gate the feature behind a new requirement or just treat it as a cache to be warmed by those who can and ignored by other. The advantage of using the cache approach is a transparent upgrade/downgrade story, making the feature easier to move to. However having out of date cache can come with a significant performance hit for process who expect an up to date cache but found none. In this case the file needs to be stored under `.hg/cache`. The "requirement" approach guarantee that the persistent nodemap is up to date. However, it comes with a less flexible activation story since an explicite upgrade is required. In this case the file can be stored in `.hg/store`. This wiki page is relevant to this questions: https://www.mercurial-scm.org/wiki/ComputedIndexPlan So which one should we take? Another element came into plan, the persistent nodemap use the `add` method of the transaction, it is used to keep track of a file content before a transaction in case we need to rollback it back. It turns out that the `transaction.add` API does not support file stored anywhere than `.hg/store`. Making it support file stored elsewhere is possible, require a change in on disk transaction format. Updating on disk file requires… introducing a new requirements. As a result, we pick the second option "gating the persistent nodemap behind a new requirements". Differential Revision: https://phab.mercurial-scm.org/D8417

     1

#!/usr/bin/env python

     2

#

     3

# Dumps output generated by Mercurial's command server in a formatted style to a

     4

# given file or stderr if '-' is specified. Output is also written in its raw

     5

# format to stdout.

     6

#

     7

# $ ./hg serve --cmds pipe | ./contrib/debugcmdserver.py -

     8

# o, 52   -> 'capabilities: getencoding runcommand\nencoding: UTF-8'

     9

    10

from __future__ import absolute_import, print_function

    11

import struct

    12

import sys

    13

    14

if len(sys.argv) != 2:

    15

    print('usage: debugcmdserver.py FILE')

    16

    sys.exit(1)

    17

    18

outputfmt = '>cI'

    19

outputfmtsize = struct.calcsize(outputfmt)

    20

    21

if sys.argv[1] == '-':

    22

    log = sys.stderr

    23

else:

    24

    log = open(sys.argv[1], 'a')

    25

    26

    27

def read(size):

    28

    data = sys.stdin.read(size)

    29

    if not data:

    30

        raise EOFError

    31

    sys.stdout.write(data)

    32

    sys.stdout.flush()

    33

    return data

    34

    35

    36

try:

    37

    while True:

    38

        header = read(outputfmtsize)

    39

        channel, length = struct.unpack(outputfmt, header)

    40

        log.write('%s, %-4d' % (channel, length))

    41

        if channel in 'IL':

    42

            log.write(' -> waiting for input\n')

    43

        else:

    44

            data = read(length)

    45

            log.write(' -> %r\n' % data)

    46

        log.flush()

    47

except EOFError:

    48

    pass

    49

finally:

    50

    if log != sys.stderr:

    51

        log.close()