repoview: separate concerns in _filteredrepotypes comment The cited issue in Python bugtracker is closed, but hasn't been fixed. We've been able to use the attached example and reproduce it with Python 3.9. The point where it turns from needless stress on the GC to the an actual leak is when one factors in the fact that the GC was before Python 3.4 unable to collect some types (see PEP 442). Note that even with Python 2.7, the simple example of cycles due to __mro__ are collectable. This was seen again with the example attached on the CPython issue.

     1

  $ hg init

     2

     3

  $ "$PYTHON" -c 'open("a", "wb").write(b"confuse str.splitlines\nembedded\rnewline\n")'

     4

  $ hg ci -Ama -d '1 0'

     5

  adding a

     6

     7

  $ echo clean diff >> a

     8

  $ hg ci -mb -d '2 0'

     9

    10

  $ hg diff -r0 -r1

    11

  diff -r 107ba6f817b5 -r 310ce7989cdc a

    12

  --- a/a	Thu Jan 01 00:00:01 1970 +0000

    13

  +++ b/a	Thu Jan 01 00:00:02 1970 +0000

    14

  @@ -1,2 +1,3 @@

    15

   confuse str.splitlines

    16

   embedded\r (no-eol) (esc)

    17

  newline

    18

  +clean diff

    19