phases: use revision number in new_heads All graph operations will be done using revision numbers, so passing nodes only means they will eventually get converted to revision numbers internally. As part of an effort to align the code on using revision number we make the `phases.newheads` function operated on revision number, taking them as input and using them in returns, instead of the node-id it used to consume and produce. This is part of multiple changesets effort to translate more part of the logic, but is done step by step to facilitate the identification of issue that might arise in mercurial core and extensions. To make the change simpler to handle for third party extensions, we also rename the function, using a more modern form. This will help detecting the different between the node-id version and the rev-num version. I also take this as an opportunity to add some comment about possible performance improvement for the future. They don't matter too much now, but they are worse exploring in a while.

     1

     2

  $ cat > unix2mac.py <<EOF

     3

  > import sys

     4

  > 

     5

  > for path in sys.argv[1:]:

     6

  >     data = open(path, 'rb').read()

     7

  >     data = data.replace(b'\n', b'\r')

     8

  >     open(path, 'wb').write(data)

     9

  > EOF

    10

  $ hg init

    11

  $ echo '[hooks]' >> .hg/hgrc

    12

  $ echo 'pretxncommit.cr = python:hgext.win32text.forbidcr' >> .hg/hgrc

    13

  $ echo 'pretxnchangegroup.cr = python:hgext.win32text.forbidcr' >> .hg/hgrc

    14

  $ cat .hg/hgrc

    15

  [hooks]

    16

  pretxncommit.cr = python:hgext.win32text.forbidcr

    17

  pretxnchangegroup.cr = python:hgext.win32text.forbidcr

    18

    19

  $ echo hello > f

    20

  $ hg add f

    21

  $ hg ci -m 1

    22

    23

  $ "$PYTHON" unix2mac.py f

    24

  $ hg ci -m 2

    25

  attempt to commit or push text file(s) using CR line endings

    26

  in dea860dc51ec: f

    27

  transaction abort!

    28

  rollback completed

    29

  abort: pretxncommit.cr hook failed

    30

  [40]

    31

  $ hg cat f | f --hexdump

    32

    33

  0000: 68 65 6c 6c 6f 0a                               |hello.|

    34

  $ f --hexdump f

    35

  f:

    36

  0000: 68 65 6c 6c 6f 0d                               |hello.|