phases: use revision number in new_heads All graph operations will be done using revision numbers, so passing nodes only means they will eventually get converted to revision numbers internally. As part of an effort to align the code on using revision number we make the `phases.newheads` function operated on revision number, taking them as input and using them in returns, instead of the node-id it used to consume and produce. This is part of multiple changesets effort to translate more part of the logic, but is done step by step to facilitate the identification of issue that might arise in mercurial core and extensions. To make the change simpler to handle for third party extensions, we also rename the function, using a more modern form. This will help detecting the different between the node-id version and the rev-num version. I also take this as an opportunity to add some comment about possible performance improvement for the future. They don't matter too much now, but they are worse exploring in a while.

     1

  $ rm -rf a

     2

  $ hg init a

     3

  $ cd a

     4

  $ echo a > a

     5

  $ hg ci -Am0

     6

  adding a

     7

  $ hg tag t1 # 1

     8

  $ hg tag --remove t1 # 2

     9

    10

  $ hg co 1

    11

  1 files updated, 0 files merged, 0 files removed, 0 files unresolved

    12

  $ hg tag -f -r0 t1

    13

  $ hg tags

    14

  tip                                3:a49829c4fc11

    15

  t1                                 0:f7b1eb17ad24

    16

    17

Ensure that the username access fails gracefully if assumptions about the

    18

environment made by python do not hold.

    19

    20

#if windows

    21

  >>> import os

    22

  >>> from mercurial import util

    23

  >>> os.environ.pop('LOGNAME', None) and None

    24

  >>> os.environ.pop('USER', None) and None

    25

  >>> os.environ.pop('LNAME', None) and None

    26

  >>> os.environ.pop('USERNAME', None) and None

    27

  >>> print(util.username())

    28

  None

    29

#endif

    30

    31

  $ cd ..