phases: use revision number in new_heads All graph operations will be done using revision numbers, so passing nodes only means they will eventually get converted to revision numbers internally. As part of an effort to align the code on using revision number we make the `phases.newheads` function operated on revision number, taking them as input and using them in returns, instead of the node-id it used to consume and produce. This is part of multiple changesets effort to translate more part of the logic, but is done step by step to facilitate the identification of issue that might arise in mercurial core and extensions. To make the change simpler to handle for third party extensions, we also rename the function, using a more modern form. This will help detecting the different between the node-id version and the rev-num version. I also take this as an opportunity to add some comment about possible performance improvement for the future. They don't matter too much now, but they are worse exploring in a while.

     1

  $ hg init repo

     2

  $ cd repo

     3

     4

  $ cat > a <<EOF

     5

  > a

     6

  > b

     7

  > c

     8

  > EOF

     9

  $ hg ci -Am adda

    10

  adding a

    11

    12

  $ cat > a <<EOF

    13

  > d

    14

  > e

    15

  > f

    16

  > EOF

    17

  $ hg ci -m moda

    18

    19

  $ hg diff --reverse -r0 -r1

    20

  diff -r 2855cdcfcbb7 -r 8e1805a3cf6e a

    21

  --- a/a	Thu Jan 01 00:00:00 1970 +0000

    22

  +++ b/a	Thu Jan 01 00:00:00 1970 +0000

    23

  @@ -1,3 +1,3 @@

    24

  -d

    25

  -e

    26

  -f

    27

  +a

    28

  +b

    29

  +c

    30

    31

  $ cat >> a <<EOF

    32

  > g

    33

  > h

    34

  > EOF

    35

  $ hg diff --reverse --nodates

    36

  diff -r 2855cdcfcbb7 a

    37

  --- a/a

    38

  +++ b/a

    39

  @@ -1,5 +1,3 @@

    40

   d

    41

   e

    42

   f

    43

  -g

    44

  -h

    45

    46

should show removed file 'a' as being added

    47

  $ hg revert a

    48

  $ hg rm a

    49

  $ hg diff --reverse --nodates a

    50

  diff -r 2855cdcfcbb7 a

    51

  --- /dev/null

    52

  +++ b/a

    53

  @@ -0,0 +1,3 @@

    54

  +d

    55

  +e

    56

  +f

    57

    58

should show added file 'b' as being removed

    59

  $ echo b >> b

    60

  $ hg add b

    61

  $ hg diff --reverse --nodates b

    62

  diff -r 2855cdcfcbb7 b

    63

  --- a/b

    64

  +++ /dev/null

    65

  @@ -1,1 +0,0 @@

    66

  -b