phases: use revision number in new_heads All graph operations will be done using revision numbers, so passing nodes only means they will eventually get converted to revision numbers internally. As part of an effort to align the code on using revision number we make the `phases.newheads` function operated on revision number, taking them as input and using them in returns, instead of the node-id it used to consume and produce. This is part of multiple changesets effort to translate more part of the logic, but is done step by step to facilitate the identification of issue that might arise in mercurial core and extensions. To make the change simpler to handle for third party extensions, we also rename the function, using a more modern form. This will help detecting the different between the node-id version and the rev-num version. I also take this as an opportunity to add some comment about possible performance improvement for the future. They don't matter too much now, but they are worse exploring in a while.

     1

#ifndef HG_BDIFF_H

     2

#define HG_BDIFF_H

     3

     4

#include "compat.h"

     5

     6

struct bdiff_line {

     7

	int hash, n, e;

     8

	ssize_t len;

     9

	const char *l;

    10

};

    11

    12

struct bdiff_hunk;

    13

struct bdiff_hunk {

    14

	int a1, a2, b1, b2;

    15

	struct bdiff_hunk *next;

    16

};

    17

    18

int bdiff_splitlines(const char *a, ssize_t len, struct bdiff_line **lr);

    19

int bdiff_diff(struct bdiff_line *a, int an, struct bdiff_line *b, int bn,

    20

               struct bdiff_hunk *base);

    21

void bdiff_freehunks(struct bdiff_hunk *l);

    22

    23

#endif