push: rework the computation of fallbackheads to be correct The previous computation tried to be smart but ended up being wrong. This was caught by phase movement test while reworking the phase discovery logic to be faster. The previous logic was failing to catch case where the pushed set was not based on a common heads (i.e. when the discovery seemed to have "over discovered" content, outside the pushed set) In the following graph, `e` is a common head and we `hg push -r f`. We need to detect `c` as a fallback heads and we previous failed to do so:: e | d f |/ c | b | a The performance impact of the change seems minimal. On the most impacted repository at hand (mozilla-try), the slowdown seems mostly mixed in the overall noise `hg push` but seems to be in the hundred of milliseconds order of magnitude. When using rust, we seems to be a bit faster, probably because we leverage more accelaratd internals. I added a couple of performance related common for further investigation later on.

     1

  $ NO_FALLBACK="env RHG_ON_UNSUPPORTED=abort"

     2

     3

  $ cat << EOF >> $HGRCPATH

     4

  > [format]

     5

  > sparse-revlog = no

     6

  > EOF

     7

     8

  $ hg init repo --config format.generaldelta=no --config format.usegeneraldelta=no

     9

  $ cd repo

    10

  $ (echo header; seq.py 20) > f

    11

  $ hg commit -q -Am initial

    12

  $ (echo header; seq.py 20; echo footer) > f

    13

  $ hg commit -q -Am x

    14

  $ hg update ".^"

    15

  1 files updated, 0 files merged, 0 files removed, 0 files unresolved

    16

  $ (seq.py 20; echo footer) > f

    17

  $ hg commit -q -Am y

    18

  $ hg debugdeltachain f --template '{rev} {prevrev} {deltatype}\n'

    19

  0 -1 base

    20

  1 0 prev

    21

  2 1 prev

    22

    23

rhg works on non-generaldelta revlogs:

    24

    25

  $ $NO_FALLBACK hg cat f -r .

    26

  1

    27

  2

    28

  3

    29

  4

    30

  5

    31

  6

    32

  7

    33

  8

    34

  9

    35

  10

    36

  11

    37

  12

    38

  13

    39

  14

    40

  15

    41

  16

    42

  17

    43

  18

    44

  19

    45

  20

    46

  footer