push: rework the computation of fallbackheads to be correct The previous computation tried to be smart but ended up being wrong. This was caught by phase movement test while reworking the phase discovery logic to be faster. The previous logic was failing to catch case where the pushed set was not based on a common heads (i.e. when the discovery seemed to have "over discovered" content, outside the pushed set) In the following graph, `e` is a common head and we `hg push -r f`. We need to detect `c` as a fallback heads and we previous failed to do so:: e | d f |/ c | b | a The performance impact of the change seems minimal. On the most impacted repository at hand (mozilla-try), the slowdown seems mostly mixed in the overall noise `hg push` but seems to be in the hundred of milliseconds order of magnitude. When using rust, we seems to be a bit faster, probably because we leverage more accelaratd internals. I added a couple of performance related common for further investigation later on.

     1

#require no-windows

     2

     3

#testcases safe normal

     4

     5

#if safe

     6

  $ echo "[format]"         >> $HGRCPATH

     7

  $ echo "exp-share-safe = True" >> $HGRCPATH

     8

#endif

     9

    10

  $ . "$TESTDIR/remotefilelog-library.sh"

    11

    12

  $ cat >> $HGRCPATH <<EOF

    13

  > [extensions]

    14

  > remotefilelog=

    15

  > share=

    16

  > EOF

    17

    18

  $ hg init master

    19

  $ cd master

    20

  $ cat >> .hg/hgrc <<EOF

    21

  > [remotefilelog]

    22

  > server=True

    23

  > EOF

    24

  $ echo x > x

    25

  $ hg commit -qAm x

    26

    27

  $ cd ..

    28

    29

    30

  $ hgcloneshallow ssh://user@dummy/master source --noupdate -q

    31

  $ hg share source dest

    32

  updating working directory

    33

  1 files updated, 0 files merged, 0 files removed, 0 files unresolved

    34

  $ hg -R dest unshare