push: rework the computation of fallbackheads to be correct The previous computation tried to be smart but ended up being wrong. This was caught by phase movement test while reworking the phase discovery logic to be faster. The previous logic was failing to catch case where the pushed set was not based on a common heads (i.e. when the discovery seemed to have "over discovered" content, outside the pushed set) In the following graph, `e` is a common head and we `hg push -r f`. We need to detect `c` as a fallback heads and we previous failed to do so:: e | d f |/ c | b | a The performance impact of the change seems minimal. On the most impacted repository at hand (mozilla-try), the slowdown seems mostly mixed in the overall noise `hg push` but seems to be in the hundred of milliseconds order of magnitude. When using rust, we seems to be a bit faster, probably because we leverage more accelaratd internals. I added a couple of performance related common for further investigation later on.

     1

  $ . "$TESTDIR/narrow-library.sh"

     2

  $ hg init master

     3

  $ cd master

     4

  $ echo treemanifest >> .hg/requires

     5

  $ echo 'contents of file' > file

     6

  $ mkdir foo

     7

  $ echo 'contents of foo/bar' > foo/bar

     8

  $ hg ci -Am 'some change'

     9

  adding file

    10

  adding foo/bar

    11

    12

  $ cd ..

    13

  $ hg clone --narrow ssh://user@dummy/master copy --include=foo

    14

  requesting all changes

    15

  adding changesets

    16

  adding manifests

    17

  adding file changes

    18

  added 1 changesets with 1 changes to 1 files

    19

  new changesets * (glob)

    20

  updating to branch default

    21

  1 files updated, 0 files merged, 0 files removed, 0 files unresolved

    22

  $ cd copy

    23

    24

  $ hg debugdirstate --no-dates

    25

  n *         20 *               foo/bar (glob)

    26

  $ mv .hg/dirstate .hg/old_dirstate

    27

  $ dd bs=40 count=1 if=.hg/old_dirstate of=.hg/dirstate 2>/dev/null

    28

  $ hg debugdirstate

    29

  $ hg debugrebuilddirstate

    30

  $ hg debugdirstate

    31

  n *         * unset               foo/bar (glob)