largefiles: avoid unnecessary creation of .hg/largefiles when opening lfdirstate Previously, the directory '.hg/largefiles' would always be created if it didn't exist when the lfdirstate was opened. If there were no standin files, no dirstate file would be created in the directory. The end result was that enabling the largefiles extension globally, but not explicitly adding a largefile would result in the repository eventually sprouting this directory. Creation of this directory effectively changes readonly operations like summary and status into operations that require write access. Without write access, commands that would succeed without the extension loaded would abort with a surprising error when the extension is loaded, but not actively used: $ hg sum -R /tmp/thg --config extensions.largefiles= parent: 16541:00dc703d5aed repowidget: specify incoming bundle by plain file path to avoid url parsing branch: default abort: Permission denied: '/tmp/thg/.hg/largefiles' This change is simpler than changing the callers of openlfdirstate() to use the 'create' parameter that was introduced in ae57920ac188, and probably how that should have been implemented in the first place.

     1

  $ hg init

     2

  $ echo a > a

     3

  $ hg add a

     4

  $ hg commit -m test

     5

     6

Do we ever miss a sub-second change?:

     7

     8

  $ for i in 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20; do

     9

  >     hg co -qC 0

    10

  >     echo b > a

    11

  >     hg st

    12

  > done

    13

  M a

    14

  M a

    15

  M a

    16

  M a

    17

  M a

    18

  M a

    19

  M a

    20

  M a

    21

  M a

    22

  M a

    23

  M a

    24

  M a

    25

  M a

    26

  M a

    27

  M a

    28

  M a

    29

  M a

    30

  M a

    31

  M a

    32

  M a

    33