transaction: allow running file generators after finalizers Previously, transaction.close would run the file generators before running the finalizers (see the list below for what is in each). Since file generators contain the bookmarks and the dirstate, this meant we made the dirstate and bookmarks visible to external readers before we actually wrote the commits into the changelog, which could result in missing bookmarks and missing working copy parents (especially on servers with high commit throughput, since pulls might fail to see certain bookmarks in this situation). By moving the changelog writing to be before the bookmark/dirstate writing, we ensure the commits are present before they are referenced. This implementation allows certain file generators to be after the finalizers. We didn't want to move all of the generators, since it's important that things like phases actually run before the finalizers (otherwise you could expose commits as public when they really shouldn't be). For reference, file generators currently consist of: bookmarks, dirstate, and phases. Finalizers currently consist of: changelog, revbranchcache, and fncache.

     1

test --time

     2

     3

  $ hg --time help -q help 2>&1 | grep time > /dev/null

     4

  $ hg init a

     5

  $ cd a

     6

     7

#if lsprof

     8

     9

test --profile

    10

    11

  $ hg --profile st 2>../out

    12

  $ grep CallCount ../out > /dev/null || cat ../out

    13

    14

  $ hg --profile --config profiling.output=../out st

    15

  $ grep CallCount ../out > /dev/null || cat ../out

    16

    17

  $ hg --profile --config profiling.output=blackbox --config extensions.blackbox= st

    18

  $ grep CallCount .hg/blackbox.log > /dev/null || cat .hg/blackbox.log

    19

    20

  $ hg --profile --config profiling.format=text st 2>../out

    21

  $ grep CallCount ../out > /dev/null || cat ../out

    22

    23

  $ echo "[profiling]" >> $HGRCPATH

    24

  $ echo "format=kcachegrind" >> $HGRCPATH

    25

    26

  $ hg --profile st 2>../out

    27

  $ grep 'events: Ticks' ../out > /dev/null || cat ../out

    28

    29

  $ hg --profile --config profiling.output=../out st

    30

  $ grep 'events: Ticks' ../out > /dev/null || cat ../out

    31

    32

#endif

    33

    34

  $ cd ..