transaction: allow running file generators after finalizers Previously, transaction.close would run the file generators before running the finalizers (see the list below for what is in each). Since file generators contain the bookmarks and the dirstate, this meant we made the dirstate and bookmarks visible to external readers before we actually wrote the commits into the changelog, which could result in missing bookmarks and missing working copy parents (especially on servers with high commit throughput, since pulls might fail to see certain bookmarks in this situation). By moving the changelog writing to be before the bookmark/dirstate writing, we ensure the commits are present before they are referenced. This implementation allows certain file generators to be after the finalizers. We didn't want to move all of the generators, since it's important that things like phases actually run before the finalizers (otherwise you could expose commits as public when they really shouldn't be). For reference, file generators currently consist of: bookmarks, dirstate, and phases. Finalizers currently consist of: changelog, revbranchcache, and fncache.

     1

https://bz.mercurial-scm.org/612

     2

     3

  $ hg init

     4

  $ mkdir src

     5

  $ echo a > src/a.c

     6

  $ hg ci -Ama

     7

  adding src/a.c

     8

     9

  $ hg mv src source

    10

  moving src/a.c to source/a.c (glob)

    11

    12

  $ hg ci -Ammove

    13

    14

  $ hg co -C 0

    15

  1 files updated, 0 files merged, 1 files removed, 0 files unresolved

    16

    17

  $ echo new > src/a.c

    18

  $ echo compiled > src/a.o

    19

  $ hg ci -mupdate

    20

  created new head

    21

    22

  $ hg status

    23

  ? src/a.o

    24

    25

  $ hg merge

    26

  merging src/a.c and source/a.c to source/a.c

    27

  0 files updated, 1 files merged, 0 files removed, 0 files unresolved

    28

  (branch merge, don't forget to commit)

    29

    30

  $ hg status

    31

  M source/a.c

    32

  R src/a.c

    33

  ? src/a.o

    34