subrepo: append subrepo path to subrepo error messages This change appends the subrepo path to subrepo errors. That is, when there is an error performing an operation a subrepo, rather than displaying a message such as: pushing subrepo MYSUBREPO to PATH searching for changes abort: push creates new remote head HEADHASH! hint: did you forget to merge? use push -f to force mercurial will show: pushing subrepo MYSUBREPO to PATH searching for changes abort: push creates new remote head HEADHASH! (in subrepo MYSUBREPO) hint: did you forget to merge? use push -f to force The rationale for this change is that the current error messages make it hard for TortoiseHg (and similar tools) to tell the user which subrepo caused the push failure. The "(in subrepo MYSUBREPO)" message has been added to those subrepo methods were it made sense (by using a decorator). We avoid appending "(in subrepo XXX)" multiple times when subrepos are nexted by throwing a "SubrepoAbort" exception after the extra message is appended. The decorator will then "ignore" (i.e. just re-raise) the exception and never add the message again. A small drawback of this method is that part of the exception trace is lost when the exception is catched and re-raised by the annotatesubrepoerror decorator. Also, because the state() function already printed the subrepo path when it threw an error, that error has been changed to avoid duplicating the subrepo path in the error message. Note that I have also updated several subrepo related tests to reflect these changes.

     1

#!/usr/bin/env python

     2

#

     3

# Wrapper script around the convert.py hgext extension

     4

# for foreign SCM conversion to mercurial format.

     5

#

     6

     7

import sys

     8

from mercurial import ui, fancyopts

     9

from hgext import convert

    10

    11

# Options extracted from the cmdtable

    12

func, options, help = convert.cmdtable['convert']

    13

    14

# An ui instance

    15

u = ui.ui()

    16

    17

opts = {}

    18

args = []

    19

try:

    20

    args = list(fancyopts.fancyopts(sys.argv[1:], options, opts))

    21

    args += [None]*(3 - len(args))

    22

    src, dest, revmapfile = args

    23

except (fancyopts.getopt.GetoptError, ValueError), inst:

    24

    u.warn('Usage:\n%s\n' % help)

    25

    sys.exit(-1)

    26

    27

convert.convert(u, src, dest, revmapfile, **opts)