posix: always seek to EOF when opening a file in append mode Python 3 already does this, so skip it there. Consider the program: #include <stdio.h> int main() { FILE *f = fopen("narf", "w"); fprintf(f, "narf\n"); fclose(f); f = fopen("narf", "a"); printf("%ld\n", ftell(f)); fprintf(f, "troz\n"); printf("%ld\n", ftell(f)); return 0; } on macOS, FreeBSD, and Linux with glibc, this program prints 5 10 but on musl libc (Alpine Linux and probably others) this prints 0 10 By my reading of https://pubs.opengroup.org/onlinepubs/009695399/functions/fopen.html this is technically correct, specifically: > Opening a file with append mode (a as the first character in the > mode argument) shall cause all subsequent writes to the file to be > forced to the then current end-of-file, regardless of intervening > calls to fseek(). in other words, the file position doesn't really matter in append-mode files, and we can't depend on it being at all meaningful unless we perform a seek() before tell() after open(..., 'a'). Experimentally after a .write() we can do a .tell() and it'll always be reasonable, but I'm unclear from reading the specification if that's a smart thing to rely on. This matches what we do on Windows and what Python 3 does for free, so let's just be consistent. Thanks to Yuya for the idea.

     1

#require symlink

     2

     3

https://bz.mercurial-scm.org/1438

     4

     5

  $ hg init

     6

     7

  $ ln -s foo link

     8

  $ hg add link

     9

  $ hg ci -mbad link

    10

  $ hg rm link

    11

  $ hg ci -mok

    12

  $ hg diff -g -r 0:1 > bad.patch

    13

    14

  $ hg up 0

    15

  1 files updated, 0 files merged, 0 files removed, 0 files unresolved

    16

    17

  $ hg import --no-commit bad.patch

    18

  applying bad.patch

    19

    20

  $ hg status

    21

  R link

    22

  ? bad.patch

    23