Mercurial Mercurial > mercurial / annotate
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | file | latest | revisions | annotate | diff | comparison | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
CONTRIBUTORS
author Augie Fackler <augie@google.com>
Mon, 08 Jul 2019 13:12:20 -0400
branchstable
changeset 42562 97ada9b8d51b
parent 5514 c29efd272395
permissions -rw-r--r--
posix: always seek to EOF when opening a file in append mode Python 3 already does this, so skip it there. Consider the program: #include <stdio.h> int main() { FILE *f = fopen("narf", "w"); fprintf(f, "narf\n"); fclose(f); f = fopen("narf", "a"); printf("%ld\n", ftell(f)); fprintf(f, "troz\n"); printf("%ld\n", ftell(f)); return 0; } on macOS, FreeBSD, and Linux with glibc, this program prints 5 10 but on musl libc (Alpine Linux and probably others) this prints 0 10 By my reading of https://pubs.opengroup.org/onlinepubs/009695399/functions/fopen.html this is technically correct, specifically: > Opening a file with append mode (a as the first character in the > mode argument) shall cause all subsequent writes to the file to be > forced to the then current end-of-file, regardless of intervening > calls to fseek(). in other words, the file position doesn't really matter in append-mode files, and we can't depend on it being at all meaningful unless we perform a seek() before tell() after open(..., 'a'). Experimentally after a .write() we can do a .tell() and it'll always be reasonable, but I'm unclear from reading the specification if that's a smart thing to rely on. This matches what we do on Windows and what Python 3 does for free, so let's just be consistent. Thanks to Yuya for the idea.
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
5514
c29efd272395 Add note to CONTRIBUTORS file
Matt Mackall <mpm@selenic.com>
parents: 2947
diff changeset 
     1
 
[This file is here for historical purposes, all recent contributors
c29efd272395 Add note to CONTRIBUTORS file
Matt Mackall <mpm@selenic.com>
parents: 2947
diff changeset 
     2
 
should appear in the changelog directly]
c29efd272395 Add note to CONTRIBUTORS file
Matt Mackall <mpm@selenic.com>
parents: 2947
diff changeset 
     3
 












c29efd272395
Add note to CONTRIBUTORS file



Matt Mackall <mpm@selenic.com>


parents: 
2947

diff
changeset




     4


Andrea Arcangeli <andrea at suse.de>







519






50768efaf6f2
Add a CONTRIBUTORS file



mpm@selenic.com


parents: 

diff
changeset




     5


Thomas Arendsen Hein <thomas at intevation.de>












50768efaf6f2
Add a CONTRIBUTORS file



mpm@selenic.com


parents: 

diff
changeset




     6


Goffredo Baroncelli <kreijack at libero.it>







756






5d79dfa5e98f
Added new code contributors, fixed Vincent's name, added hint on encoding.



Thomas Arendsen Hein <thomas@intevation.de>


parents: 
594

diff
changeset




     7


Muli Ben-Yehuda <mulix at mulix.org>












5d79dfa5e98f
Added new code contributors, fixed Vincent's name, added hint on encoding.



Thomas Arendsen Hein <thomas@intevation.de>


parents: 
594

diff
changeset




     8


Mikael Berthe <mikael at lilotux.net>







1450






199bb2b4ed4a
Add Benoit to CONTRIBUTORS



Matt Mackall <mpm@selenic.com>


parents: 
1310

diff
changeset




     9


Benoit Boissinot <bboissin at gmail.com>







2947






2d865068f72e
Add self to contributors



Brendan Cully <brendan@kublai.com>


parents: 
2162

diff
changeset




    10


Brendan Cully <brendan at kublai.com>







519






50768efaf6f2
Add a CONTRIBUTORS file



mpm@selenic.com


parents: 

diff
changeset




    11


Vincent Danjean <vdanjean.ml at free.fr>












50768efaf6f2
Add a CONTRIBUTORS file



mpm@selenic.com


parents: 

diff
changeset




    12


Jake Edge <jake at edge2.net>












50768efaf6f2
Add a CONTRIBUTORS file



mpm@selenic.com


parents: 

diff
changeset




    13


Michael Fetterman <michael.fetterman at intel.com>












50768efaf6f2
Add a CONTRIBUTORS file



mpm@selenic.com


parents: 

diff
changeset




    14


Edouard Gomez <ed.gomez at free.fr>







1231






effff847870f
CONTRIBUTORS update



mpm@selenic.com


parents: 
1080

diff
changeset




    15


Eric Hopper <hopper at omnifarious.org>







756






5d79dfa5e98f
Added new code contributors, fixed Vincent's name, added hint on encoding.



Thomas Arendsen Hein <thomas@intevation.de>


parents: 
594

diff
changeset




    16


Alecs King <alecsk at gmail.com>







1310






7e8a55c9ee5c
Updated CONTRIBUTORS.



Thomas Arendsen Hein <thomas@intevation.de>


parents: 
1231

diff
changeset




    17


Volker Kleinfeld <Volker.Kleinfeld at gmx.de>







519






50768efaf6f2
Add a CONTRIBUTORS file



mpm@selenic.com


parents: 

diff
changeset




    18


Vadim Lebedev <vadim at mbdsys.com>












50768efaf6f2
Add a CONTRIBUTORS file



mpm@selenic.com


parents: 

diff
changeset




    19


Christopher Li <hg at chrisli.org>












50768efaf6f2
Add a CONTRIBUTORS file



mpm@selenic.com


parents: 

diff
changeset




    20


Chris Mason <mason at suse.com>







2162






dac432a521d8
Add self to CONTRIBUTORS



Colin McMillen <mcmillen@cs.cmu.edu>


parents: 
2120

diff
changeset




    21


Colin McMillen <mcmillen at cs.cmu.edu>







1080






253072f39205
Updated list of contributors.



Thomas Arendsen Hein <thomas@intevation.de>


parents: 
896

diff
changeset




    22


Wojciech Milkowski <wmilkowski at interia.pl>







756






5d79dfa5e98f
Added new code contributors, fixed Vincent's name, added hint on encoding.



Thomas Arendsen Hein <thomas@intevation.de>


parents: 
594

diff
changeset




    23


Chad Netzer <chad.netzer at gmail.com>







519






50768efaf6f2
Add a CONTRIBUTORS file



mpm@selenic.com


parents: 

diff
changeset




    24


Bryan O'Sullivan <bos at serpentine.com>







756






5d79dfa5e98f
Added new code contributors, fixed Vincent's name, added hint on encoding.



Thomas Arendsen Hein <thomas@intevation.de>


parents: 
594

diff
changeset




    25


Vicent Seguí Pascual <vseguip at gmail.com>












5d79dfa5e98f
Added new code contributors, fixed Vincent's name, added hint on encoding.



Thomas Arendsen Hein <thomas@intevation.de>


parents: 
594

diff
changeset




    26


Sean Perry <shaleh at speakeasy.net>







594






0a2ffc5c906b
Update CONTRIBUTORS



mpm@selenic.com


parents: 
519

diff
changeset




    27


Nguyen Anh Quynh <aquynh at gmail.com>







1310






7e8a55c9ee5c
Updated CONTRIBUTORS.



Thomas Arendsen Hein <thomas@intevation.de>


parents: 
1231

diff
changeset




    28


Ollivier Robert <roberto at keltia.freenix.fr>







2120






c0994047c5ff
Added my name to the contributors list.



Alexander Schremmer <alex AT alexanderweb DOT de>


parents: 
1450

diff
changeset




    29


Alexander Schremmer <alex at alexanderweb.de>







519






50768efaf6f2
Add a CONTRIBUTORS file



mpm@selenic.com


parents: 

diff
changeset




    30


Arun Sharma <arun at sharma-home.net>







1231






effff847870f
CONTRIBUTORS update



mpm@selenic.com


parents: 
1080

diff
changeset




    31


Josef "Jeff" Sipek <jeffpc at optonline.net>







1310






7e8a55c9ee5c
Updated CONTRIBUTORS.



Thomas Arendsen Hein <thomas@intevation.de>


parents: 
1231

diff
changeset




    32


Kevin Smith <yarcs at qualitycode.com>







1231






effff847870f
CONTRIBUTORS update



mpm@selenic.com


parents: 
1080

diff
changeset




    33


TK Soh <teekaysoh at yahoo.com>







519






50768efaf6f2
Add a CONTRIBUTORS file



mpm@selenic.com


parents: 

diff
changeset




    34


Radoslaw Szkodzinski <astralstorm at gorzow.mm.pl>







851






73a432c8040a
Added Samuel Tardieu to contributors list.



Thomas Arendsen Hein <thomas@intevation.de>


parents: 
760

diff
changeset




    35


Samuel Tardieu <sam at rfc1149.net>







519






50768efaf6f2
Add a CONTRIBUTORS file



mpm@selenic.com


parents: 

diff
changeset




    36


K Thananchayan <thananck at yahoo.com>












50768efaf6f2
Add a CONTRIBUTORS file



mpm@selenic.com


parents: 

diff
changeset




    37


Andrew Thompson <andrewkt at aktzero.com>












50768efaf6f2
Add a CONTRIBUTORS file



mpm@selenic.com


parents: 

diff
changeset




    38


Michael S. Tsirkin <mst at mellanox.co.il>












50768efaf6f2
Add a CONTRIBUTORS file



mpm@selenic.com


parents: 

diff
changeset




    39


Rafael Villar Burke <pachi at mmn-arquitectos.com>







855






a107c64c76be
Added Tristan Wibberley to contributors.



Thomas Arendsen Hein <thomas@intevation.de>


parents: 
851

diff
changeset




    40


Tristan Wibberley <tristan at wibberley.org>







756






5d79dfa5e98f
Added new code contributors, fixed Vincent's name, added hint on encoding.



Thomas Arendsen Hein <thomas@intevation.de>


parents: 
594

diff
changeset




    41


Mark Williamson <mark.williamson at cl.cam.ac.uk>














mercurial