status: prefer relative paths in Rust code … when the repository root is under the current directory, so the kernel needs to traverse fewer directory in every call to `read_dir` or `symlink_metadata`. Better yet would be to use libc functions like `openat` and `fstatat` to remove such repeated traversals entirely, but the standard library does not provide APIs based on those. Maybe with a crate like https://crates.io/crates/openat instead? Benchmarks of `rhg status` show that this patch is neutral in some configurations, and makes the command up to ~20% faster in others. Below is semi-arbitrary subset of results. The four numeric columns are: time (in seconds) with this changeset’s parent, time with this changeset, time difference (negative is better), time ratio (less than 1 is better). ``` mercurial-dirstate-v1 | default-plain-clean.no-iu.pbr | 0.0061 -> 0.0059: -0.0002 (0.97) mercurial-dirstate-v2 | default-plain-clean.no-iu.pbr | 0.0029 -> 0.0028: -0.0001 (0.97) mozilla-dirstate-v1 | default-plain-clean.no-iu.pbr | 0.2110 -> 0.2102: -0.0007 (1.00) mozilla-dirstate-v2 | default-copies-clean.ignored.pbr | 0.0489 -> 0.0401: -0.0088 (0.82) mozilla-dirstate-v2 | default-copies-clean.no-iu.pbr | 0.0479 -> 0.0393: -0.0085 (0.82) mozilla-dirstate-v2 | default-copies-large.all.pbr | 0.1262 -> 0.1210: -0.0051 (0.96) mozilla-dirstate-v2 | default-copies-small.ignored-unknown.pbr | 0.1262 -> 0.1200: -0.0062 (0.95) mozilla-dirstate-v2 | default-copies-small.ignored.pbr | 0.0536 -> 0.0417: -0.0119 (0.78) mozilla-dirstate-v2 | default-copies-small.no-iu.pbr | 0.0482 -> 0.0393: -0.0089 (0.81) mozilla-dirstate-v2 | default-plain-clean.ignored.pbr | 0.0518 -> 0.0402: -0.0116 (0.78) mozilla-dirstate-v2 | default-plain-clean.no-iu.pbr | 0.0481 -> 0.0392: -0.0088 (0.82) mozilla-dirstate-v2 | default-plain-large.all.pbr | 0.1271 -> 0.1218: -0.0052 (0.96) mozilla-dirstate-v2 | default-plain-small.ignored-unknown.pbr | 0.1225 -> 0.1202: -0.0022 (0.98) mozilla-dirstate-v2 | default-plain-small.ignored.pbr | 0.0510 -> 0.0418: -0.0092 (0.82) mozilla-dirstate-v2 | default-plain-small.no-iu.pbr | 0.0480 -> 0.0394: -0.0086 (0.82) netbeans-dirstate-v1 | default-plain-clean.no-iu.pbr | 0.1442 -> 0.1422: -0.0020 (0.99) netbeans-dirstate-v2 | default-plain-clean.no-iu.pbr | 0.0325 -> 0.0282: -0.0043 (0.87) ``` Differential Revision: https://phab.mercurial-scm.org/D12175

     1

"""

     2

List-valued configuration keys have an ad-hoc microsyntax. From `hg help config`:

     3

     4

> List values are separated by whitespace or comma, except when values are

     5

> placed in double quotation marks:

     6

>

     7

>     allow_read = "John Doe, PhD", brian, betty

     8

>

     9

> Quotation marks can be escaped by prefixing them with a backslash. Only

    10

> quotation marks at the beginning of a word is counted as a quotation

    11

> (e.g., ``foo"bar baz`` is the list of ``foo"bar`` and ``baz``).

    12

    13

That help documentation is fairly light on details, the actual parser has many

    14

other edge cases. This test tries to cover them.

    15

"""

    16

    17

from mercurial.utils import stringutil

    18

    19

    20

def assert_parselist(input, expected):

    21

    result = stringutil.parselist(input)

    22

    if result != expected:

    23

        raise AssertionError(

    24

            "parse_input(%r)\n     got %r\nexpected %r"

    25

            % (input, result, expected)

    26

        )

    27

    28

    29

# Keep these Python tests in sync with the Rust ones in `rust/hg-core/src/config/values.rs`

    30

    31

assert_parselist(b'', [])

    32

assert_parselist(b',', [])

    33

assert_parselist(b'A', [b'A'])

    34

assert_parselist(b'B,B', [b'B', b'B'])

    35

assert_parselist(b', C, ,C,', [b'C', b'C'])

    36

assert_parselist(b'"', [b'"'])

    37

assert_parselist(b'""', [b'', b''])

    38

assert_parselist(b'D,"', [b'D', b'"'])

    39

assert_parselist(b'E,""', [b'E', b'', b''])

    40

assert_parselist(b'"F,F"', [b'F,F'])

    41

assert_parselist(b'"G,G', [b'"G', b'G'])

    42

assert_parselist(b'"H \\",\\"H', [b'"H', b',', b'H'])

    43

assert_parselist(b'I,I"', [b'I', b'I"'])

    44

assert_parselist(b'J,"J', [b'J', b'"J'])

    45

assert_parselist(b'K K', [b'K', b'K'])

    46

assert_parselist(b'"K" K', [b'K', b'K'])

    47

assert_parselist(b'L\tL', [b'L', b'L'])

    48

assert_parselist(b'"L"\tL', [b'L', b'', b'L'])

    49

assert_parselist(b'M\x0bM', [b'M', b'M'])

    50

assert_parselist(b'"M"\x0bM', [b'M', b'', b'M'])

    51

assert_parselist(b'"N"  , ,"', [b'N"'])

    52

assert_parselist(b'" ,O,  ', [b'"', b'O'])