status: prefer relative paths in Rust code … when the repository root is under the current directory, so the kernel needs to traverse fewer directory in every call to `read_dir` or `symlink_metadata`. Better yet would be to use libc functions like `openat` and `fstatat` to remove such repeated traversals entirely, but the standard library does not provide APIs based on those. Maybe with a crate like https://crates.io/crates/openat instead? Benchmarks of `rhg status` show that this patch is neutral in some configurations, and makes the command up to ~20% faster in others. Below is semi-arbitrary subset of results. The four numeric columns are: time (in seconds) with this changeset’s parent, time with this changeset, time difference (negative is better), time ratio (less than 1 is better). ``` mercurial-dirstate-v1 | default-plain-clean.no-iu.pbr | 0.0061 -> 0.0059: -0.0002 (0.97) mercurial-dirstate-v2 | default-plain-clean.no-iu.pbr | 0.0029 -> 0.0028: -0.0001 (0.97) mozilla-dirstate-v1 | default-plain-clean.no-iu.pbr | 0.2110 -> 0.2102: -0.0007 (1.00) mozilla-dirstate-v2 | default-copies-clean.ignored.pbr | 0.0489 -> 0.0401: -0.0088 (0.82) mozilla-dirstate-v2 | default-copies-clean.no-iu.pbr | 0.0479 -> 0.0393: -0.0085 (0.82) mozilla-dirstate-v2 | default-copies-large.all.pbr | 0.1262 -> 0.1210: -0.0051 (0.96) mozilla-dirstate-v2 | default-copies-small.ignored-unknown.pbr | 0.1262 -> 0.1200: -0.0062 (0.95) mozilla-dirstate-v2 | default-copies-small.ignored.pbr | 0.0536 -> 0.0417: -0.0119 (0.78) mozilla-dirstate-v2 | default-copies-small.no-iu.pbr | 0.0482 -> 0.0393: -0.0089 (0.81) mozilla-dirstate-v2 | default-plain-clean.ignored.pbr | 0.0518 -> 0.0402: -0.0116 (0.78) mozilla-dirstate-v2 | default-plain-clean.no-iu.pbr | 0.0481 -> 0.0392: -0.0088 (0.82) mozilla-dirstate-v2 | default-plain-large.all.pbr | 0.1271 -> 0.1218: -0.0052 (0.96) mozilla-dirstate-v2 | default-plain-small.ignored-unknown.pbr | 0.1225 -> 0.1202: -0.0022 (0.98) mozilla-dirstate-v2 | default-plain-small.ignored.pbr | 0.0510 -> 0.0418: -0.0092 (0.82) mozilla-dirstate-v2 | default-plain-small.no-iu.pbr | 0.0480 -> 0.0394: -0.0086 (0.82) netbeans-dirstate-v1 | default-plain-clean.no-iu.pbr | 0.1442 -> 0.1422: -0.0020 (0.99) netbeans-dirstate-v2 | default-plain-clean.no-iu.pbr | 0.0325 -> 0.0282: -0.0043 (0.87) ``` Differential Revision: https://phab.mercurial-scm.org/D12175

     1

# Extension dedicated to test patch.diff() upgrade modes

     2

     3

from __future__ import absolute_import

     4

     5

from mercurial import (

     6

    error,

     7

    logcmdutil,

     8

    patch,

     9

    pycompat,

    10

    registrar,

    11

    scmutil,

    12

)

    13

    14

cmdtable = {}

    15

command = registrar.command(cmdtable)

    16

    17

    18

@command(

    19

    b'autodiff',

    20

    [(b'', b'git', b'', b'git upgrade mode (yes/no/auto/warn/abort)')],

    21

    b'[OPTION]... [FILE]...',

    22

)

    23

def autodiff(ui, repo, *pats, **opts):

    24

    opts = pycompat.byteskwargs(opts)

    25

    diffopts = patch.difffeatureopts(ui, opts)

    26

    git = opts.get(b'git', b'no')

    27

    brokenfiles = set()

    28

    losedatafn = None

    29

    if git in (b'yes', b'no'):

    30

        diffopts.git = git == b'yes'

    31

        diffopts.upgrade = False

    32

    elif git == b'auto':

    33

        diffopts.git = False

    34

        diffopts.upgrade = True

    35

    elif git == b'warn':

    36

        diffopts.git = False

    37

        diffopts.upgrade = True

    38

    39

        def losedatafn(fn=None, **kwargs):

    40

            brokenfiles.add(fn)

    41

            return True

    42

    43

    elif git == b'abort':

    44

        diffopts.git = False

    45

        diffopts.upgrade = True

    46

    47

        def losedatafn(fn=None, **kwargs):

    48

            raise error.Abort(b'losing data for %s' % fn)

    49

    50

    else:

    51

        raise error.Abort(b'--git must be yes, no or auto')

    52

    53

    ctx1, ctx2 = logcmdutil.revpair(repo, [])

    54

    m = scmutil.match(ctx2, pats, opts)

    55

    it = patch.diff(

    56

        repo,

    57

        ctx1.node(),

    58

        ctx2.node(),

    59

        match=m,

    60

        opts=diffopts,

    61

        losedatafn=losedatafn,

    62

    )

    63

    for chunk in it:

    64

        ui.write(chunk)

    65

    for fn in sorted(brokenfiles):

    66

        ui.write((b'data lost for: %s\n' % fn))