status: prefer relative paths in Rust code … when the repository root is under the current directory, so the kernel needs to traverse fewer directory in every call to `read_dir` or `symlink_metadata`. Better yet would be to use libc functions like `openat` and `fstatat` to remove such repeated traversals entirely, but the standard library does not provide APIs based on those. Maybe with a crate like https://crates.io/crates/openat instead? Benchmarks of `rhg status` show that this patch is neutral in some configurations, and makes the command up to ~20% faster in others. Below is semi-arbitrary subset of results. The four numeric columns are: time (in seconds) with this changeset’s parent, time with this changeset, time difference (negative is better), time ratio (less than 1 is better). ``` mercurial-dirstate-v1 | default-plain-clean.no-iu.pbr | 0.0061 -> 0.0059: -0.0002 (0.97) mercurial-dirstate-v2 | default-plain-clean.no-iu.pbr | 0.0029 -> 0.0028: -0.0001 (0.97) mozilla-dirstate-v1 | default-plain-clean.no-iu.pbr | 0.2110 -> 0.2102: -0.0007 (1.00) mozilla-dirstate-v2 | default-copies-clean.ignored.pbr | 0.0489 -> 0.0401: -0.0088 (0.82) mozilla-dirstate-v2 | default-copies-clean.no-iu.pbr | 0.0479 -> 0.0393: -0.0085 (0.82) mozilla-dirstate-v2 | default-copies-large.all.pbr | 0.1262 -> 0.1210: -0.0051 (0.96) mozilla-dirstate-v2 | default-copies-small.ignored-unknown.pbr | 0.1262 -> 0.1200: -0.0062 (0.95) mozilla-dirstate-v2 | default-copies-small.ignored.pbr | 0.0536 -> 0.0417: -0.0119 (0.78) mozilla-dirstate-v2 | default-copies-small.no-iu.pbr | 0.0482 -> 0.0393: -0.0089 (0.81) mozilla-dirstate-v2 | default-plain-clean.ignored.pbr | 0.0518 -> 0.0402: -0.0116 (0.78) mozilla-dirstate-v2 | default-plain-clean.no-iu.pbr | 0.0481 -> 0.0392: -0.0088 (0.82) mozilla-dirstate-v2 | default-plain-large.all.pbr | 0.1271 -> 0.1218: -0.0052 (0.96) mozilla-dirstate-v2 | default-plain-small.ignored-unknown.pbr | 0.1225 -> 0.1202: -0.0022 (0.98) mozilla-dirstate-v2 | default-plain-small.ignored.pbr | 0.0510 -> 0.0418: -0.0092 (0.82) mozilla-dirstate-v2 | default-plain-small.no-iu.pbr | 0.0480 -> 0.0394: -0.0086 (0.82) netbeans-dirstate-v1 | default-plain-clean.no-iu.pbr | 0.1442 -> 0.1422: -0.0020 (0.99) netbeans-dirstate-v2 | default-plain-clean.no-iu.pbr | 0.0325 -> 0.0282: -0.0043 (0.87) ``` Differential Revision: https://phab.mercurial-scm.org/D12175

     1

# pushkey.py - dispatching for pushing and pulling keys

     2

#

     3

# Copyright 2010 Olivia Mackall <olivia@selenic.com>

     4

#

     5

# This software may be used and distributed according to the terms of the

     6

# GNU General Public License version 2 or any later version.

     7

     8

from __future__ import absolute_import

     9

    10

from . import (

    11

    bookmarks,

    12

    encoding,

    13

    obsolete,

    14

    phases,

    15

)

    16

    17

    18

def _nslist(repo):

    19

    n = {}

    20

    for k in _namespaces:

    21

        n[k] = b""

    22

    if not obsolete.isenabled(repo, obsolete.exchangeopt):

    23

        n.pop(b'obsolete')

    24

    return n

    25

    26

    27

_namespaces = {

    28

    b"namespaces": (lambda *x: False, _nslist),

    29

    b"bookmarks": (bookmarks.pushbookmark, bookmarks.listbookmarks),

    30

    b"phases": (phases.pushphase, phases.listphases),

    31

    b"obsolete": (obsolete.pushmarker, obsolete.listmarkers),

    32

}

    33

    34

    35

def register(namespace, pushkey, listkeys):

    36

    _namespaces[namespace] = (pushkey, listkeys)

    37

    38

    39

def _get(namespace):

    40

    return _namespaces.get(namespace, (lambda *x: False, lambda *x: {}))

    41

    42

    43

def push(repo, namespace, key, old, new):

    44

    '''should succeed iff value was old'''

    45

    pk = _get(namespace)[0]

    46

    return pk(repo, key, old, new)

    47

    48

    49

def list(repo, namespace):

    50

    '''return a dict'''

    51

    lk = _get(namespace)[1]

    52

    return lk(repo)

    53

    54

    55

encode = encoding.fromlocal

    56

    57

decode = encoding.tolocal

    58

    59

    60

def encodekeys(keys):

    61

    """encode the content of a pushkey namespace for exchange over the wire"""

    62

    return b'\n'.join([b'%s\t%s' % (encode(k), encode(v)) for k, v in keys])

    63

    64

    65

def decodekeys(data):

    66

    """decode the content of a pushkey namespace from exchange over the wire"""

    67

    result = {}

    68

    for l in data.splitlines():

    69

        k, v = l.split(b'\t')

    70

        result[decode(k)] = decode(v)

    71

    return result