status: prefer relative paths in Rust code … when the repository root is under the current directory, so the kernel needs to traverse fewer directory in every call to `read_dir` or `symlink_metadata`. Better yet would be to use libc functions like `openat` and `fstatat` to remove such repeated traversals entirely, but the standard library does not provide APIs based on those. Maybe with a crate like https://crates.io/crates/openat instead? Benchmarks of `rhg status` show that this patch is neutral in some configurations, and makes the command up to ~20% faster in others. Below is semi-arbitrary subset of results. The four numeric columns are: time (in seconds) with this changeset’s parent, time with this changeset, time difference (negative is better), time ratio (less than 1 is better). ``` mercurial-dirstate-v1 | default-plain-clean.no-iu.pbr | 0.0061 -> 0.0059: -0.0002 (0.97) mercurial-dirstate-v2 | default-plain-clean.no-iu.pbr | 0.0029 -> 0.0028: -0.0001 (0.97) mozilla-dirstate-v1 | default-plain-clean.no-iu.pbr | 0.2110 -> 0.2102: -0.0007 (1.00) mozilla-dirstate-v2 | default-copies-clean.ignored.pbr | 0.0489 -> 0.0401: -0.0088 (0.82) mozilla-dirstate-v2 | default-copies-clean.no-iu.pbr | 0.0479 -> 0.0393: -0.0085 (0.82) mozilla-dirstate-v2 | default-copies-large.all.pbr | 0.1262 -> 0.1210: -0.0051 (0.96) mozilla-dirstate-v2 | default-copies-small.ignored-unknown.pbr | 0.1262 -> 0.1200: -0.0062 (0.95) mozilla-dirstate-v2 | default-copies-small.ignored.pbr | 0.0536 -> 0.0417: -0.0119 (0.78) mozilla-dirstate-v2 | default-copies-small.no-iu.pbr | 0.0482 -> 0.0393: -0.0089 (0.81) mozilla-dirstate-v2 | default-plain-clean.ignored.pbr | 0.0518 -> 0.0402: -0.0116 (0.78) mozilla-dirstate-v2 | default-plain-clean.no-iu.pbr | 0.0481 -> 0.0392: -0.0088 (0.82) mozilla-dirstate-v2 | default-plain-large.all.pbr | 0.1271 -> 0.1218: -0.0052 (0.96) mozilla-dirstate-v2 | default-plain-small.ignored-unknown.pbr | 0.1225 -> 0.1202: -0.0022 (0.98) mozilla-dirstate-v2 | default-plain-small.ignored.pbr | 0.0510 -> 0.0418: -0.0092 (0.82) mozilla-dirstate-v2 | default-plain-small.no-iu.pbr | 0.0480 -> 0.0394: -0.0086 (0.82) netbeans-dirstate-v1 | default-plain-clean.no-iu.pbr | 0.1442 -> 0.1422: -0.0020 (0.99) netbeans-dirstate-v2 | default-plain-clean.no-iu.pbr | 0.0325 -> 0.0282: -0.0043 (0.87) ``` Differential Revision: https://phab.mercurial-scm.org/D12175

     1

#!/usr/bin/env python3

     2

#

     3

# docchecker - look for problematic markup

     4

#

     5

# Copyright 2016 timeless <timeless@mozdev.org> and others

     6

#

     7

# This software may be used and distributed according to the terms of the

     8

# GNU General Public License version 2 or any later version.

     9

    10

from __future__ import absolute_import, print_function

    11

    12

import os

    13

import re

    14

import sys

    15

    16

try:

    17

    import msvcrt

    18

    19

    msvcrt.setmode(sys.stdout.fileno(), os.O_BINARY)

    20

    msvcrt.setmode(sys.stderr.fileno(), os.O_BINARY)

    21

except ImportError:

    22

    pass

    23

    24

stdout = getattr(sys.stdout, 'buffer', sys.stdout)

    25

    26

leadingline = re.compile(br'(^\s*)(\S.*)$')

    27

    28

checks = [

    29

    (

    30

        br""":hg:`[^`]*'[^`]*`""",

    31

        b"""warning: please avoid nesting ' in :hg:`...`""",

    32

    ),

    33

    (br'\w:hg:`', b'warning: please have a space before :hg:'),

    34

    (

    35

        br"""(?:[^a-z][^'.])hg ([^,;"`]*'(?!hg)){2}""",

    36

        b'''warning: please use " instead of ' for hg ... "..."''',

    37

    ),

    38

]

    39

    40

    41

def check(line):

    42

    messages = []

    43

    for match, msg in checks:

    44

        if re.search(match, line):

    45

            messages.append(msg)

    46

    if messages:

    47

        stdout.write(b'%s\n' % line)

    48

        for msg in messages:

    49

            stdout.write(b'%s\n' % msg)

    50

    51

    52

def work(file):

    53

    (llead, lline) = (b'', b'')

    54

    55

    for line in file:

    56

        # this section unwraps lines

    57

        match = leadingline.match(line)

    58

        if not match:

    59

            check(lline)

    60

            (llead, lline) = (b'', b'')

    61

            continue

    62

    63

        lead, line = match.group(1), match.group(2)

    64

        if lead == llead:

    65

            if lline != b'':

    66

                lline += b' ' + line

    67

            else:

    68

                lline = line

    69

        else:

    70

            check(lline)

    71

            (llead, lline) = (lead, line)

    72

    check(lline)

    73

    74

    75

def main():

    76

    for f in sys.argv[1:]:

    77

        try:

    78

            with open(f, 'rb') as file:

    79

                work(file)

    80

        except BaseException as e:

    81

            sys.stdout.write(r"failed to process %s: %s\n" % (f, e))

    82

    83

    84

main()