ssh: unban the use of pipe character in user@host:port string This vulnerability was fixed by the previous patch and there were more ways to exploit than using '|shellcmd'. So it doesn't make sense to reject only pipe character. Test cases are updated to actually try to exploit the bug. As the SSH bridge of git/svn subrepos are not managed by our code, the tests for non-hg subrepos are just removed. This may be folded into the original patches.

     1

#require serve killdaemons

     2

     3

  $ hg clone http://localhost:$HGPORT/ copy

     4

  abort: * (glob)

     5

  [255]

     6

     7

  $ test -d copy

     8

  [1]

     9

    10

  $ python "$TESTDIR/dumbhttp.py" -p $HGPORT --pid dumb.pid

    11

  $ cat dumb.pid >> $DAEMON_PIDS

    12

  $ hg clone http://localhost:$HGPORT/foo copy2

    13

  abort: HTTP Error 404: * (glob)

    14

  [255]

    15

  $ killdaemons.py