httppeer: refactor how httppeer is created (API) Previously, we passed a bunch of arguments to httppeer.__init__, validated them, then possibly constructed a valid instance. A short while ago, we refactored sshpeer so all the validation and setup work occurs before the constructor. We introduced a makepeer() to hold most of this logic. This commit gives httppeer the same treatment. As a sign that the previous design was poor, __del__ no longer conditionally checks for the presence of an attribute that may not be defined (it is always defined in the new code). .. api:: httppeer.httppeer.__init__ now takes additional arguments. Instances should be obtained by calling httppeer.instance() or httppeer.makepeer() instead. Differential Revision: https://phab.mercurial-scm.org/D2725

     1

% lazy ancestor set for [], stoprev = 0, inclusive = False

     2

membership: []

     3

iteration:  []

     4

% lazy ancestor set for [11, 13], stoprev = 0, inclusive = False

     5

membership: [7, 8, 3, 4, 1, 0]

     6

iteration:  [3, 7, 8, 1, 4, 0, 2]

     7

% lazy ancestor set for [1, 3], stoprev = 0, inclusive = False

     8

membership: [1, 0]

     9

iteration:  [0, 1]

    10

% lazy ancestor set for [11, 13], stoprev = 0, inclusive = True

    11

membership: [11, 13, 7, 8, 3, 4, 1, 0]

    12

iteration:  [11, 13, 3, 7, 8, 1, 4, 0, 2]

    13

% lazy ancestor set for [11, 13], stoprev = 6, inclusive = False

    14

membership: [7, 8]

    15

iteration:  [7, 8]

    16

% lazy ancestor set for [11, 13], stoprev = 6, inclusive = True

    17

membership: [11, 13, 7, 8]

    18

iteration:  [11, 13, 7, 8]