check-code: detect "missing _() in ui message" more exactly Before this patch, "missing _() in ui message" rule overlooks translatable message, which starts with other than alphabet. To detect "missing _() in ui message" more exactly, this patch improves the regexp with assumptions below. - sequence consisting of below might precede "translatable message" in same string token - formatting string, which starts with '%' - escaped character, which starts with 'b' (as replacement of '\\'), or - characters other than '%', 'b' and 'x' (as replacement of alphabet) - any string tokens might precede a string token, which contains "translatable message" This patch builds an input file, which is used to examine "missing _() in ui message" detection, before '"$check_code" stringjoin.py' in test-contrib-check-code.t, because this reduces amount of change churn in subsequent patch. This patch also applies "()" instead of "_()" on messages below to hide false-positives: - messages for ui.debug() or debug commands/tools - contrib/debugshell.py - hgext/win32mbcs.py (ui.write() is used, though) - mercurial/commands.py - _debugchangegroup - debugindex - debuglocks - debugrevlog - debugrevspec - debugtemplate - untranslatable messages - doc/gendoc.py (ReST specific text) - hgext/hgk.py (permission string) - hgext/keyword.py (text written into configuration file) - mercurial/cmdutil.py (formatting strings for JSON)

     1

# debugshell extension

     2

"""a python shell with repo, changelog & manifest objects"""

     3

     4

from __future__ import absolute_import

     5

import code

     6

import mercurial

     7

import sys

     8

from mercurial import (

     9

    cmdutil,

    10

    demandimport,

    11

)

    12

    13

cmdtable = {}

    14

command = cmdutil.command(cmdtable)

    15

    16

def pdb(ui, repo, msg, **opts):

    17

    objects = {

    18

        'mercurial': mercurial,

    19

        'repo': repo,

    20

        'cl': repo.changelog,

    21

        'mf': repo.manifest,

    22

    }

    23

    24

    code.interact(msg, local=objects)

    25

    26

def ipdb(ui, repo, msg, **opts):

    27

    import IPython

    28

    29

    cl = repo.changelog

    30

    mf = repo.manifest

    31

    cl, mf # use variables to appease pyflakes

    32

    33

    IPython.embed()

    34

    35

@command('debugshell|dbsh', [])

    36

def debugshell(ui, repo, **opts):

    37

    bannermsg = "loaded repo : %s\n" \

    38

                "using source: %s" % (repo.root,

    39

                                      mercurial.__path__[0])

    40

    41

    pdbmap = {

    42

        'pdb'  : 'code',

    43

        'ipdb' : 'IPython'

    44

    }

    45

    46

    debugger = ui.config("ui", "debugger")

    47

    if not debugger:

    48

        debugger = 'pdb'

    49

    50

    # if IPython doesn't exist, fallback to code.interact

    51

    try:

    52

        with demandimport.deactivated():

    53

            __import__(pdbmap[debugger])

    54

    except ImportError:

    55

        ui.warn(("%s debugger specified but %s module was not found\n")

    56

                % (debugger, pdbmap[debugger]))

    57

        debugger = 'pdb'

    58

    59

    getattr(sys.modules[__name__], debugger)(ui, repo, bannermsg, **opts)