graftcopies: remove `skip` and `repo` arguments The `skip` argument was added in 2ba6c9b4e0eb (rebase: fix bug that caused transitive copy records to disappear (issue4192), 2014-06-07) in order to fix https://bz.mercurial-scm.org/show_bug.cgi?id=4192. I ran tests at that commit without the `skiprev` argument and the only difference I noticed was that `test-rebase-collapse.t` failed differently, in the call that is now on line 501. Without the `skiprev` argument, that call would end up creating another commit because it tried to record an invalid copy. With the previous patch in this series, such invalid copies are no longer recorded, so it seems we don't need the `skip` argument anymore. I also removed the `repo` argument since that also becomes unused with the removal of the `skip` argument. Differential Revision: https://phab.mercurial-scm.org/D7860

     1

Address commentary in manifest.excludedmanifestrevlog.add -

     2

specifically we should improve the collaboration with core so that

     3

add() never gets called on an excluded directory and we can improve

     4

the stand-in to raise a ProgrammingError.

     5

     6

Reason more completely about rename-filtering logic in

     7

narrowfilelog. There could be some surprises lurking there.

     8

     9

Formally document the narrowspec format. For bonus points, unify with the

    10

server-specified narrowspec format.

    11

    12

narrowrepo.setnarrowpats() or narrowspec.save() need to make sure

    13

they're holding the wlock.

    14

    15

The follinwg places do an unrestricted dirstate walk (including files outside the

    16

narrowspec). Some of them should perhaps not do that.

    17

    18

 * debugfileset

    19

 * perfwalk

    20

 * sparse (but restricted to sparse config)

    21

 * largefiles