procutils: don't try to get `.buffer` if sys.stdin is None While hunting down following test failure of test-chg.t on Python 3, I stumbled the case when `.buffer` is not available as sys.stdin is None. --- /home/pulkit/repo/hg-committed/tests/test-chg.t +++ /home/pulkit/repo/hg-committed/tests/test-chg.t.err @@ -203,7 +203,31 @@ $ CHGDEBUG=1 chg version -q 0<&- chg: debug: * stdio fds are missing (glob) chg: debug: * execute original hg (glob) - Mercurial Distributed SCM * (glob) + Traceback (most recent call last): + File "/tmp/hgtests.avspvsq4/install/bin/hg", line 43, in <module> + dispatch.run() + File "/usr/lib/python3.6/importlib/util.py", line 233, in __getattribute__ + self.__spec__.loader.exec_module(self) + File "<frozen importlib._bootstrap_external>", line 678, in exec_module + File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed + File "/tmp/hgtests.avspvsq4/install/lib/python/mercurial/dispatch.py", line 726, in <module> + class lazyaliasentry(object): + File "/tmp/hgtests.avspvsq4/install/lib/python/mercurial/dispatch.py", line 737, in lazyaliasentry + @util.propertycache + File "/usr/lib/python3.6/importlib/util.py", line 233, in __getattribute__ + self.__spec__.loader.exec_module(self) + File "<frozen importlib._bootstrap_external>", line 678, in exec_module + File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed + File "/tmp/hgtests.avspvsq4/install/lib/python/mercurial/util.py", line 3473, in <module> + f=procutil.stderr, + File "/usr/lib/python3.6/importlib/util.py", line 233, in __getattribute__ + self.__spec__.loader.exec_module(self) + File "<frozen importlib._bootstrap_external>", line 678, in exec_module + File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed + File "/tmp/hgtests.avspvsq4/install/lib/python/mercurial/utils/procutil.py", line 127, in <module> + stdin = sys.stdin.buffer + AttributeError: 'NoneType' object has no attribute 'buffer' + [1] server lifecycle ---------------- Differential Revision: https://phab.mercurial-scm.org/D9500

     1

  $ cat <<EOF >> $HGRCPATH

     2

  > [extensions]

     3

  > hooklib =

     4

  > 

     5

  > [phases]

     6

  > publish = False

     7

  > EOF

     8

  $ hg init a

     9

  $ hg --cwd a debugbuilddag .

    10

  $ hg --cwd a phase --public 0

    11

  $ hg init b

    12

  $ cat <<EOF >> b/.hg/hgrc

    13

  > [hooks]

    14

  > pretxnclose-phase.enforce_draft_commits = \

    15

  >   python:hgext.hooklib.enforce_draft_commits.hook

    16

  > EOF

    17

  $ hg --cwd b pull ../a

    18

  pulling from ../a

    19

  requesting all changes

    20

  adding changesets

    21

  adding manifests

    22

  adding file changes

    23

  error: pretxnclose-phase.enforce_draft_commits hook failed: New changeset 1ea73414a91b in phase 'public' rejected

    24

  transaction abort!

    25

  rollback completed

    26

  abort: New changeset 1ea73414a91b in phase 'public' rejected

    27

  [255]

    28

  $ hg --cwd a phase --force --draft 0

    29

  $ hg --cwd b pull ../a

    30

  pulling from ../a

    31

  requesting all changes

    32

  adding changesets

    33

  adding manifests

    34

  adding file changes

    35

  added 1 changesets with 0 changes to 0 files

    36

  new changesets 1ea73414a91b (1 drafts)

    37

  (run 'hg update' to get a working copy)

    38

  $ hg --cwd a phase --public 0

    39

  $ hg --cwd b pull ../a

    40

  pulling from ../a

    41

  searching for changes

    42

  no changes found

    43

  error: pretxnclose-phase.enforce_draft_commits hook failed: Phase change from 'draft' to 'public' for 1ea73414a91b rejected

    44

  abort: Phase change from 'draft' to 'public' for 1ea73414a91b rejected

    45

  [255]