procutils: don't try to get `.buffer` if sys.stdin is None While hunting down following test failure of test-chg.t on Python 3, I stumbled the case when `.buffer` is not available as sys.stdin is None. --- /home/pulkit/repo/hg-committed/tests/test-chg.t +++ /home/pulkit/repo/hg-committed/tests/test-chg.t.err @@ -203,7 +203,31 @@ $ CHGDEBUG=1 chg version -q 0<&- chg: debug: * stdio fds are missing (glob) chg: debug: * execute original hg (glob) - Mercurial Distributed SCM * (glob) + Traceback (most recent call last): + File "/tmp/hgtests.avspvsq4/install/bin/hg", line 43, in <module> + dispatch.run() + File "/usr/lib/python3.6/importlib/util.py", line 233, in __getattribute__ + self.__spec__.loader.exec_module(self) + File "<frozen importlib._bootstrap_external>", line 678, in exec_module + File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed + File "/tmp/hgtests.avspvsq4/install/lib/python/mercurial/dispatch.py", line 726, in <module> + class lazyaliasentry(object): + File "/tmp/hgtests.avspvsq4/install/lib/python/mercurial/dispatch.py", line 737, in lazyaliasentry + @util.propertycache + File "/usr/lib/python3.6/importlib/util.py", line 233, in __getattribute__ + self.__spec__.loader.exec_module(self) + File "<frozen importlib._bootstrap_external>", line 678, in exec_module + File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed + File "/tmp/hgtests.avspvsq4/install/lib/python/mercurial/util.py", line 3473, in <module> + f=procutil.stderr, + File "/usr/lib/python3.6/importlib/util.py", line 233, in __getattribute__ + self.__spec__.loader.exec_module(self) + File "<frozen importlib._bootstrap_external>", line 678, in exec_module + File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed + File "/tmp/hgtests.avspvsq4/install/lib/python/mercurial/utils/procutil.py", line 127, in <module> + stdin = sys.stdin.buffer + AttributeError: 'NoneType' object has no attribute 'buffer' + [1] server lifecycle ---------------- Differential Revision: https://phab.mercurial-scm.org/D9500

     1

Create an empty repo:

     2

     3

  $ hg init a

     4

  $ cd a

     5

     6

Try some commands:

     7

     8

  $ hg log

     9

  $ hg grep wah

    10

  [1]

    11

  $ hg manifest

    12

  $ hg verify

    13

  checking changesets

    14

  checking manifests

    15

  crosschecking files in changesets and manifests

    16

  checking files

    17

  checked 0 changesets with 0 changes to 0 files

    18

    19

Check the basic files created:

    20

    21

  $ ls .hg

    22

  00changelog.i

    23

  cache

    24

  requires

    25

  store

    26

  wcache

    27

    28

Should be empty:

    29

    30

  $ ls .hg/store

    31

    32

Poke at a clone:

    33

    34

  $ cd ..

    35

  $ hg clone a b

    36

  updating to branch default

    37

  0 files updated, 0 files merged, 0 files removed, 0 files unresolved

    38

  $ cd b

    39

  $ hg verify

    40

  checking changesets

    41

  checking manifests

    42

  crosschecking files in changesets and manifests

    43

  checking files

    44

  checked 0 changesets with 0 changes to 0 files

    45

  $ ls .hg

    46

  00changelog.i

    47

  hgrc

    48

  requires

    49

  store

    50

    51

Should be empty:

    52

    53

  $ ls .hg/store

    54

    55

  $ cd ..