procutils: don't try to get `.buffer` if sys.stdin is None While hunting down following test failure of test-chg.t on Python 3, I stumbled the case when `.buffer` is not available as sys.stdin is None. --- /home/pulkit/repo/hg-committed/tests/test-chg.t +++ /home/pulkit/repo/hg-committed/tests/test-chg.t.err @@ -203,7 +203,31 @@ $ CHGDEBUG=1 chg version -q 0<&- chg: debug: * stdio fds are missing (glob) chg: debug: * execute original hg (glob) - Mercurial Distributed SCM * (glob) + Traceback (most recent call last): + File "/tmp/hgtests.avspvsq4/install/bin/hg", line 43, in <module> + dispatch.run() + File "/usr/lib/python3.6/importlib/util.py", line 233, in __getattribute__ + self.__spec__.loader.exec_module(self) + File "<frozen importlib._bootstrap_external>", line 678, in exec_module + File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed + File "/tmp/hgtests.avspvsq4/install/lib/python/mercurial/dispatch.py", line 726, in <module> + class lazyaliasentry(object): + File "/tmp/hgtests.avspvsq4/install/lib/python/mercurial/dispatch.py", line 737, in lazyaliasentry + @util.propertycache + File "/usr/lib/python3.6/importlib/util.py", line 233, in __getattribute__ + self.__spec__.loader.exec_module(self) + File "<frozen importlib._bootstrap_external>", line 678, in exec_module + File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed + File "/tmp/hgtests.avspvsq4/install/lib/python/mercurial/util.py", line 3473, in <module> + f=procutil.stderr, + File "/usr/lib/python3.6/importlib/util.py", line 233, in __getattribute__ + self.__spec__.loader.exec_module(self) + File "<frozen importlib._bootstrap_external>", line 678, in exec_module + File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed + File "/tmp/hgtests.avspvsq4/install/lib/python/mercurial/utils/procutil.py", line 127, in <module> + stdin = sys.stdin.buffer + AttributeError: 'NoneType' object has no attribute 'buffer' + [1] server lifecycle ---------------- Differential Revision: https://phab.mercurial-scm.org/D9500

     1

DOCUMENT_ROOT="/var/www/hg"; export DOCUMENT_ROOT

     2

GATEWAY_INTERFACE="CGI/1.1"; export GATEWAY_INTERFACE

     3

HTTP_ACCEPT="text/xml,application/xml,application/xhtml+xml,text/html;q=0.9,text/plain;q=0.8,image/png,*/*;q=0.5"; export HTTP_ACCEPT

     4

HTTP_ACCEPT_CHARSET="ISO-8859-1,utf-8;q=0.7,*;q=0.7"; export HTTP_ACCEPT_CHARSET

     5

HTTP_ACCEPT_ENCODING="gzip,deflate"; export HTTP_ACCEPT_ENCODING

     6

HTTP_ACCEPT_LANGUAGE="en-us,en;q=0.5"; export HTTP_ACCEPT_LANGUAGE

     7

HTTP_CACHE_CONTROL="max-age=0"; export HTTP_CACHE_CONTROL

     8

HTTP_CONNECTION="keep-alive"; export HTTP_CONNECTION

     9

HTTP_HOST="hg.omnifarious.org"; export HTTP_HOST

    10

HTTP_KEEP_ALIVE="300"; export HTTP_KEEP_ALIVE

    11

HTTP_USER_AGENT="Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.0.4) Gecko/20060608 Ubuntu/dapper-security Firefox/1.5.0.4"; export HTTP_USER_AGENT

    12

PATH_INFO="/"; export PATH_INFO

    13

PATH_TRANSLATED="/var/www/hg/index.html"; export PATH_TRANSLATED

    14

QUERY_STRING=""; export QUERY_STRING

    15

REMOTE_ADDR="127.0.0.2"; export REMOTE_ADDR

    16

REMOTE_PORT="44703"; export REMOTE_PORT

    17

REQUEST_METHOD="GET"; export REQUEST_METHOD

    18

REQUEST_URI="/test/"; export REQUEST_URI

    19

SCRIPT_FILENAME="/home/hopper/hg_public/test.cgi"; export SCRIPT_FILENAME

    20

SCRIPT_NAME="/test"; export SCRIPT_NAME

    21

SCRIPT_URI="http://hg.omnifarious.org/test/"; export SCRIPT_URI

    22

SCRIPT_URL="/test/"; export SCRIPT_URL

    23

SERVER_ADDR="127.0.0.1"; export SERVER_ADDR

    24

SERVER_ADMIN="eric@localhost"; export SERVER_ADMIN

    25

SERVER_NAME="hg.omnifarious.org"; export SERVER_NAME

    26

SERVER_PORT="80"; export SERVER_PORT

    27

SERVER_PROTOCOL="HTTP/1.1"; export SERVER_PROTOCOL

    28

SERVER_SIGNATURE="<address>Apache/2.0.53 (Fedora) Server at hg.omnifarious.org Port 80</address>"; export SERVER_SIGNATURE

    29

SERVER_SOFTWARE="Apache/2.0.53 (Fedora)"; export SERVER_SOFTWARE