procutils: don't try to get `.buffer` if sys.stdin is None While hunting down following test failure of test-chg.t on Python 3, I stumbled the case when `.buffer` is not available as sys.stdin is None. --- /home/pulkit/repo/hg-committed/tests/test-chg.t +++ /home/pulkit/repo/hg-committed/tests/test-chg.t.err @@ -203,7 +203,31 @@ $ CHGDEBUG=1 chg version -q 0<&- chg: debug: * stdio fds are missing (glob) chg: debug: * execute original hg (glob) - Mercurial Distributed SCM * (glob) + Traceback (most recent call last): + File "/tmp/hgtests.avspvsq4/install/bin/hg", line 43, in <module> + dispatch.run() + File "/usr/lib/python3.6/importlib/util.py", line 233, in __getattribute__ + self.__spec__.loader.exec_module(self) + File "<frozen importlib._bootstrap_external>", line 678, in exec_module + File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed + File "/tmp/hgtests.avspvsq4/install/lib/python/mercurial/dispatch.py", line 726, in <module> + class lazyaliasentry(object): + File "/tmp/hgtests.avspvsq4/install/lib/python/mercurial/dispatch.py", line 737, in lazyaliasentry + @util.propertycache + File "/usr/lib/python3.6/importlib/util.py", line 233, in __getattribute__ + self.__spec__.loader.exec_module(self) + File "<frozen importlib._bootstrap_external>", line 678, in exec_module + File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed + File "/tmp/hgtests.avspvsq4/install/lib/python/mercurial/util.py", line 3473, in <module> + f=procutil.stderr, + File "/usr/lib/python3.6/importlib/util.py", line 233, in __getattribute__ + self.__spec__.loader.exec_module(self) + File "<frozen importlib._bootstrap_external>", line 678, in exec_module + File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed + File "/tmp/hgtests.avspvsq4/install/lib/python/mercurial/utils/procutil.py", line 127, in <module> + stdin = sys.stdin.buffer + AttributeError: 'NoneType' object has no attribute 'buffer' + [1] server lifecycle ---------------- Differential Revision: https://phab.mercurial-scm.org/D9500

     1

== New Features ==

     2

     3

 * Windows will process hgrc files in %PROGRAMDATA%\Mercurial\hgrc.d.

     4

     5

     6

== New Experimental Features ==

     7

     8

     9

== Bug Fixes  ==

    10

    11

 * The `indent()` template function was documented to not indent empty lines,

    12

   but it still indented the first line even if it was empty. It no longer does

    13

   that.

    14

    15

== Backwards Compatibility Changes ==

    16

    17

    18

== Internal API Changes ==

    19

    20

 * Matcher instances no longer have a `explicitdir` property. Consider

    21

   rewriting your code to use `repo.wvfs.isdir()` and/or

    22

   `ctx.hasdir()` instead. Also, the `traversedir` property is now

    23

   also called when only `explicitdir` used to be called. That may

    24

   mean that you can simply remove the use of `explicitdir` if you

    25

   were already using `traversedir`.

    26

    27

 * The `revlog.nodemap` object have been merged into the `revlog.index` object.

    28

   * `n in revlog.nodemap` becomes `revlog.index.has_node(n)`,

    29

   * `revlog.nodemap[n]` becomes `revlog.index.rev(n)`,

    30

   * `revlog.nodemap.get(n)` becomes `revlog.index.get_rev(n)`.

    31

    32

 * `copies.duplicatecopies()` was renamed to

    33

   `copies.graftcopies()`. Its arguments changed from revision numbers

    34

   to context objects. It also lost its `repo` and `skip` arguments

    35

   (they should no longer be needed).