procutils: don't try to get `.buffer` if sys.stdin is None While hunting down following test failure of test-chg.t on Python 3, I stumbled the case when `.buffer` is not available as sys.stdin is None. --- /home/pulkit/repo/hg-committed/tests/test-chg.t +++ /home/pulkit/repo/hg-committed/tests/test-chg.t.err @@ -203,7 +203,31 @@ $ CHGDEBUG=1 chg version -q 0<&- chg: debug: * stdio fds are missing (glob) chg: debug: * execute original hg (glob) - Mercurial Distributed SCM * (glob) + Traceback (most recent call last): + File "/tmp/hgtests.avspvsq4/install/bin/hg", line 43, in <module> + dispatch.run() + File "/usr/lib/python3.6/importlib/util.py", line 233, in __getattribute__ + self.__spec__.loader.exec_module(self) + File "<frozen importlib._bootstrap_external>", line 678, in exec_module + File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed + File "/tmp/hgtests.avspvsq4/install/lib/python/mercurial/dispatch.py", line 726, in <module> + class lazyaliasentry(object): + File "/tmp/hgtests.avspvsq4/install/lib/python/mercurial/dispatch.py", line 737, in lazyaliasentry + @util.propertycache + File "/usr/lib/python3.6/importlib/util.py", line 233, in __getattribute__ + self.__spec__.loader.exec_module(self) + File "<frozen importlib._bootstrap_external>", line 678, in exec_module + File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed + File "/tmp/hgtests.avspvsq4/install/lib/python/mercurial/util.py", line 3473, in <module> + f=procutil.stderr, + File "/usr/lib/python3.6/importlib/util.py", line 233, in __getattribute__ + self.__spec__.loader.exec_module(self) + File "<frozen importlib._bootstrap_external>", line 678, in exec_module + File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed + File "/tmp/hgtests.avspvsq4/install/lib/python/mercurial/utils/procutil.py", line 127, in <module> + stdin = sys.stdin.buffer + AttributeError: 'NoneType' object has no attribute 'buffer' + [1] server lifecycle ---------------- Differential Revision: https://phab.mercurial-scm.org/D9500

     1

[This file is here for historical purposes, all recent contributors

     2

should appear in the changelog directly]

     3

     4

Andrea Arcangeli <andrea at suse.de>

     5

Thomas Arendsen Hein <thomas at intevation.de>

     6

Goffredo Baroncelli <kreijack at libero.it>

     7

Muli Ben-Yehuda <mulix at mulix.org>

     8

Mikael Berthe <mikael at lilotux.net>

     9

Benoit Boissinot <bboissin at gmail.com>

    10

Brendan Cully <brendan at kublai.com>

    11

Vincent Danjean <vdanjean.ml at free.fr>

    12

Jake Edge <jake at edge2.net>

    13

Michael Fetterman <michael.fetterman at intel.com>

    14

Edouard Gomez <ed.gomez at free.fr>

    15

Eric Hopper <hopper at omnifarious.org>

    16

Alecs King <alecsk at gmail.com>

    17

Volker Kleinfeld <Volker.Kleinfeld at gmx.de>

    18

Vadim Lebedev <vadim at mbdsys.com>

    19

Christopher Li <hg at chrisli.org>

    20

Chris Mason <mason at suse.com>

    21

Colin McMillen <mcmillen at cs.cmu.edu>

    22

Wojciech Milkowski <wmilkowski at interia.pl>

    23

Chad Netzer <chad.netzer at gmail.com>

    24

Bryan O'Sullivan <bos at serpentine.com>

    25

Vicent Seguí Pascual <vseguip at gmail.com>

    26

Sean Perry <shaleh at speakeasy.net>

    27

Nguyen Anh Quynh <aquynh at gmail.com>

    28

Ollivier Robert <roberto at keltia.freenix.fr>

    29

Alexander Schremmer <alex at alexanderweb.de>

    30

Arun Sharma <arun at sharma-home.net>

    31

Josef "Jeff" Sipek <jeffpc at optonline.net>

    32

Kevin Smith <yarcs at qualitycode.com>

    33

TK Soh <teekaysoh at yahoo.com>

    34

Radoslaw Szkodzinski <astralstorm at gorzow.mm.pl>

    35

Samuel Tardieu <sam at rfc1149.net>

    36

K Thananchayan <thananck at yahoo.com>

    37

Andrew Thompson <andrewkt at aktzero.com>

    38

Michael S. Tsirkin <mst at mellanox.co.il>

    39

Rafael Villar Burke <pachi at mmn-arquitectos.com>

    40

Tristan Wibberley <tristan at wibberley.org>

    41

Mark Williamson <mark.williamson at cl.cam.ac.uk>