pytype: stop excluding mercurial/ui.py ui.extractchoices() is perhaps making assumptions that it shouldn't about the pattern always matching, but presumably we have test coverage for that. PyCharm flags the updated classes with a warning "Class xxx must implement all abstract methods", and suggests adding `abc.ABC` to the superclasses. I'm not sure why, unless it doesn't recognize the `__getattr__()` delegation pattern. Additionally, we can't unconditionally subclass `typing.BinaryIO` because that defeats the `__getattr__` delegation to the wrapped object at runtime. Instead, it has to only subclass during the type checking phase[1]. In any event, this fixes: File "/mnt/c/Users/Matt/hg/mercurial/ui.py", line 1518, in _runpager: Function subprocess.Popen.__new__ was called with the wrong arguments [wrong-arg-types] Expected: (cls, args, bufsize, executable, stdin, stdout: Optional[Union[IO, int]] = ..., ...) Actually passed: (cls, args, bufsize, stdin, stdout: Union[mercurial.utils.procutil.WriteAllWrapper, mercurial.windows.winstdout], ...) File "/mnt/c/Users/Matt/hg/mercurial/ui.py", line 1798, in extractchoices: No attribute 'group' on None [attribute-error] In Optional[Match[bytes]] File "/mnt/c/Users/Matt/hg/mercurial/ui.py", line 1799, in extractchoices: No attribute 'group' on None [attribute-error] In Optional[Match[bytes]] [1] https://stackoverflow.com/q/71365594

     1

# typelib.py - type hint aliases and support

     2

#

     3

# Copyright 2022 Matt Harbison <matt_harbison@yahoo.com>

     4

#

     5

# This software may be used and distributed according to the terms of the

     6

# GNU General Public License version 2 or any later version.

     7

     8

import typing

     9

    10

# Note: this is slightly different from pycompat.TYPE_CHECKING, as using

    11

# pycompat causes the BinaryIO_Proxy type to be resolved to ``object`` when

    12

# used as the base class during a pytype run.

    13

TYPE_CHECKING = typing.TYPE_CHECKING

    14

    15

    16

# The BinaryIO class provides empty methods, which at runtime means that

    17

# ``__getattr__`` on the proxy classes won't get called for the methods that

    18

# should delegate to the internal object.  So to avoid runtime changes because

    19

# of the required typing inheritance, just use BinaryIO when typechecking, and

    20

# ``object`` otherwise.

    21

if TYPE_CHECKING:

    22

    from typing import (

    23

        BinaryIO,

    24

    )

    25

    26

    BinaryIO_Proxy = BinaryIO

    27

else:

    28

    BinaryIO_Proxy = object