server: ensure the incoming request falls under the prefix value Prior to this, the first test asserted in wsgiref.validate.check_environ() saying PATH didn't start with '/', but the second test served up the repo. The assertion was just added in this cycle (though the value of PATH is still wrong without the assertion). Allowing access to the repo at any URL outside of the prefix is a long standing bug. This also affected hgwebdir, at least when used via --subrepo. Paths are not being canonicalized, so accesses to things like 'foo/../bar' will get tossed out here, unless the prefix also matches.

     1

#!/usr/bin/env python

     2

     3

from __future__ import absolute_import

     4

     5

import os

     6

import sys

     7

     8

os.chdir(os.getenv('TESTTMP'))

     9

    10

if sys.argv[1] != "user@dummy":

    11

    sys.exit(-1)

    12

    13

os.environ["SSH_CLIENT"] = "%s 1 2" % os.environ.get('LOCALIP', '127.0.0.1')

    14

    15

log = open("dummylog", "ab")

    16

log.write(b"Got arguments")

    17

for i, arg in enumerate(sys.argv[1:]):

    18

    log.write(b" %d:%s" % (i + 1, arg))

    19

log.write("\n")

    20

log.close()

    21

hgcmd = sys.argv[2]

    22

if os.name == 'nt':

    23

    # hack to make simple unix single quote quoting work on windows

    24

    hgcmd = hgcmd.replace("'", '"')

    25

r = os.system(hgcmd)

    26

sys.exit(bool(r))