dispatch: protect against malicious 'hg serve --stdio' invocations (sec) Some shared-ssh installations assume that 'hg serve --stdio' is a safe command to run for minimally trusted users. Unfortunately, the messy implementation of argument parsing here meant that trying to access a repo named '--debugger' would give the user a pdb prompt, thereby sidestepping any hoped-for sandboxing. Serving repositories over HTTP(S) is unaffected. We're not currently hardening any subcommands other than 'serve'. If your service exposes other commands to users with arbitrary repository names, it is imperative that you defend against repository names of '--debugger' and anything starting with '--config'. The read-only mode of hg-ssh stopped working because it provided its hook configuration to "hg serve --stdio" via --config parameter. This is banned for security reasons now. This patch switches it to directly call ui.setconfig(). If your custom hosting infrastructure relies on passing --config to "hg serve --stdio", you'll need to find a different way to get that configuration into Mercurial, either by using ui.setconfig() as hg-ssh does in this patch, or by placing an hgrc file someplace where Mercurial will read it. mitrandir@fb.com provided some extra fixes for the dispatch code and for hg-ssh in places that I overlooked.

     1

https://bz.mercurial-scm.org/842

     2

     3

  $ hg init

     4

  $ echo foo > a

     5

  $ hg ci -Ama

     6

  adding a

     7

     8

  $ hg up -r0000

     9

  0 files updated, 0 files merged, 1 files removed, 0 files unresolved

    10

    11

  $ echo bar > a

    12

    13

Should issue new head warning:

    14

    15

  $ hg ci -Amb

    16

  adding a

    17

  created new head

    18

    19

  $ hg up -r0000

    20

  0 files updated, 0 files merged, 1 files removed, 0 files unresolved

    21

    22

  $ echo stuffy > a

    23

    24

Should not issue new head warning:

    25

    26

  $ hg ci -q -Amc

    27

    28

  $ hg up -r0000

    29

  0 files updated, 0 files merged, 1 files removed, 0 files unresolved

    30

    31

  $ echo crap > a

    32

  $ hg branch testing

    33

  marked working directory as branch testing

    34

  (branches are permanent and global, did you want a bookmark?)

    35

    36

Should not issue warning:

    37

    38

  $ hg ci -q -Amd

    39