dispatch: protect against malicious 'hg serve --stdio' invocations (sec) Some shared-ssh installations assume that 'hg serve --stdio' is a safe command to run for minimally trusted users. Unfortunately, the messy implementation of argument parsing here meant that trying to access a repo named '--debugger' would give the user a pdb prompt, thereby sidestepping any hoped-for sandboxing. Serving repositories over HTTP(S) is unaffected. We're not currently hardening any subcommands other than 'serve'. If your service exposes other commands to users with arbitrary repository names, it is imperative that you defend against repository names of '--debugger' and anything starting with '--config'. The read-only mode of hg-ssh stopped working because it provided its hook configuration to "hg serve --stdio" via --config parameter. This is banned for security reasons now. This patch switches it to directly call ui.setconfig(). If your custom hosting infrastructure relies on passing --config to "hg serve --stdio", you'll need to find a different way to get that configuration into Mercurial, either by using ui.setconfig() as hg-ssh does in this patch, or by placing an hgrc file someplace where Mercurial will read it. mitrandir@fb.com provided some extra fixes for the dispatch code and for hg-ssh in places that I overlooked.

     1

https://bz.mercurial-scm.org/2493

     2

     3

Testing tagging with the EOL extension

     4

     5

  $ cat >> $HGRCPATH <<EOF

     6

  > [extensions]

     7

  > eol =

     8

  > 

     9

  > [eol]

    10

  > native = CRLF

    11

  > EOF

    12

    13

setup repository

    14

    15

  $ hg init repo

    16

  $ cd repo

    17

  $ cat > .hgeol <<EOF

    18

  > [patterns]

    19

  > ** = native

    20

  > EOF

    21

  $ printf "first\r\nsecond\r\nthird\r\n" > a.txt

    22

  $ hg commit --addremove -m 'checkin'

    23

  adding .hgeol

    24

  adding a.txt

    25

    26

Tag:

    27

    28

  $ hg tag 1.0

    29

    30

Rewrite .hgtags file as it would look on a new checkout:

    31

    32

  $ hg update -q null

    33

  $ hg update -q

    34

    35

Touch .hgtags file again:

    36

    37

  $ hg tag 2.0

    38

    39

  $ cd ..