dispatch: protect against malicious 'hg serve --stdio' invocations (sec) Some shared-ssh installations assume that 'hg serve --stdio' is a safe command to run for minimally trusted users. Unfortunately, the messy implementation of argument parsing here meant that trying to access a repo named '--debugger' would give the user a pdb prompt, thereby sidestepping any hoped-for sandboxing. Serving repositories over HTTP(S) is unaffected. We're not currently hardening any subcommands other than 'serve'. If your service exposes other commands to users with arbitrary repository names, it is imperative that you defend against repository names of '--debugger' and anything starting with '--config'. The read-only mode of hg-ssh stopped working because it provided its hook configuration to "hg serve --stdio" via --config parameter. This is banned for security reasons now. This patch switches it to directly call ui.setconfig(). If your custom hosting infrastructure relies on passing --config to "hg serve --stdio", you'll need to find a different way to get that configuration into Mercurial, either by using ui.setconfig() as hg-ssh does in this patch, or by placing an hgrc file someplace where Mercurial will read it. mitrandir@fb.com provided some extra fixes for the dispatch code and for hg-ssh in places that I overlooked.

     1

#require test-repo slow docker

     2

     3

  $ . "$TESTDIR/helpers-testrepo.sh"

     4

     5

Ensure debuild doesn't run the testsuite, as that could get silly.

     6

  $ DEB_BUILD_OPTIONS=nocheck

     7

  $ export DEB_BUILD_OPTIONS

     8

  $ OUTPUTDIR=`pwd`

     9

  $ export OUTPUTDIR

    10

    11

  $ cd "$TESTDIR"/..

    12

  $ make docker-debian-jessie > $OUTPUTDIR/build.log 2>&1

    13

  $ cd $OUTPUTDIR

    14

  $ ls *.deb

    15

  mercurial-common_*.deb (glob)

    16

  mercurial_*.deb (glob)

    17

    18

We check debian package contents with portable tools so that when

    19

we're on non-debian machines we can still test the packages that are

    20

built using docker.

    21

    22

main deb should have .so but no .py

    23

  $ ar x mercurial_*.deb

    24

  $ tar tf data.tar* | egrep '(localrepo|parsers)'

    25

  ./usr/lib/python2.7/dist-packages/mercurial/parsers*.so (glob)

    26

mercurial-common should have .py but no .so or .pyc

    27

  $ ar x mercurial-common_*.deb

    28

  $ tar tf data.tar* | egrep '(localrepo|parsers)'

    29

  ./usr/lib/python2.7/dist-packages/mercurial/pure/parsers.py

    30

  ./usr/lib/python2.7/dist-packages/mercurial/localrepo.py