dispatch: protect against malicious 'hg serve --stdio' invocations (sec) Some shared-ssh installations assume that 'hg serve --stdio' is a safe command to run for minimally trusted users. Unfortunately, the messy implementation of argument parsing here meant that trying to access a repo named '--debugger' would give the user a pdb prompt, thereby sidestepping any hoped-for sandboxing. Serving repositories over HTTP(S) is unaffected. We're not currently hardening any subcommands other than 'serve'. If your service exposes other commands to users with arbitrary repository names, it is imperative that you defend against repository names of '--debugger' and anything starting with '--config'. The read-only mode of hg-ssh stopped working because it provided its hook configuration to "hg serve --stdio" via --config parameter. This is banned for security reasons now. This patch switches it to directly call ui.setconfig(). If your custom hosting infrastructure relies on passing --config to "hg serve --stdio", you'll need to find a different way to get that configuration into Mercurial, either by using ui.setconfig() as hg-ssh does in this patch, or by placing an hgrc file someplace where Mercurial will read it. mitrandir@fb.com provided some extra fixes for the dispatch code and for hg-ssh in places that I overlooked.

     1

  $ for i in aaa zzz; do

     2

  >     hg init t

     3

  >     cd t

     4

  > 

     5

  >     echo

     6

  >     echo "-- With $i"

     7

  > 

     8

  >     touch file

     9

  >     hg add file

    10

  >     hg ci -m "Add"

    11

  > 

    12

  >     hg cp file $i

    13

  >     hg ci -m "a -> $i"

    14

  > 

    15

  >     hg cp $i other-file

    16

  >     echo "different" >> $i

    17

  >     hg ci -m "$i -> other-file"

    18

  > 

    19

  >     hg cp other-file somename

    20

  > 

    21

  >     echo "Status":

    22

  >     hg st -C

    23

  >     echo

    24

  >     echo "Diff:"

    25

  >     hg diff -g

    26

  > 

    27

  >     cd ..

    28

  >     rm -rf t

    29

  > done

    30

    31

  -- With aaa

    32

  Status:

    33

  A somename

    34

    other-file

    35

    36

  Diff:

    37

  diff --git a/other-file b/somename

    38

  copy from other-file

    39

  copy to somename

    40

    41

  -- With zzz

    42

  Status:

    43

  A somename

    44

    other-file

    45

    46

  Diff:

    47

  diff --git a/other-file b/somename

    48

  copy from other-file

    49

  copy to somename

    50

    51