dispatch: protect against malicious 'hg serve --stdio' invocations (sec) Some shared-ssh installations assume that 'hg serve --stdio' is a safe command to run for minimally trusted users. Unfortunately, the messy implementation of argument parsing here meant that trying to access a repo named '--debugger' would give the user a pdb prompt, thereby sidestepping any hoped-for sandboxing. Serving repositories over HTTP(S) is unaffected. We're not currently hardening any subcommands other than 'serve'. If your service exposes other commands to users with arbitrary repository names, it is imperative that you defend against repository names of '--debugger' and anything starting with '--config'. The read-only mode of hg-ssh stopped working because it provided its hook configuration to "hg serve --stdio" via --config parameter. This is banned for security reasons now. This patch switches it to directly call ui.setconfig(). If your custom hosting infrastructure relies on passing --config to "hg serve --stdio", you'll need to find a different way to get that configuration into Mercurial, either by using ui.setconfig() as hg-ssh does in this patch, or by placing an hgrc file someplace where Mercurial will read it. mitrandir@fb.com provided some extra fixes for the dispatch code and for hg-ssh in places that I overlooked.

     1

  $ cat > abortcommit.py <<EOF

     2

  > from mercurial import error

     3

  > def hook(**args):

     4

  >     raise error.Abort("no commits allowed")

     5

  > def reposetup(ui, repo):

     6

  >     repo.ui.setconfig("hooks", "pretxncommit.nocommits", hook)

     7

  > EOF

     8

  $ abspath=`pwd`/abortcommit.py

     9

    10

  $ cat <<EOF >> $HGRCPATH

    11

  > [extensions]

    12

  > mq =

    13

  > abortcommit = $abspath

    14

  > EOF

    15

    16

  $ hg init foo

    17

  $ cd foo

    18

  $ echo foo > foo

    19

  $ hg add foo

    20

    21

mq may keep a reference to the repository so __del__ will not be

    22

called and .hg/journal.dirstate will not be deleted:

    23

    24

  $ hg ci -m foo

    25

  error: pretxncommit.nocommits hook failed: no commits allowed

    26

  transaction abort!

    27

  rollback completed

    28

  abort: no commits allowed

    29

  [255]

    30

  $ hg ci -m foo

    31

  error: pretxncommit.nocommits hook failed: no commits allowed

    32

  transaction abort!

    33

  rollback completed

    34

  abort: no commits allowed

    35

  [255]

    36

    37

  $ cd ..