dispatch: protect against malicious 'hg serve --stdio' invocations (sec) Some shared-ssh installations assume that 'hg serve --stdio' is a safe command to run for minimally trusted users. Unfortunately, the messy implementation of argument parsing here meant that trying to access a repo named '--debugger' would give the user a pdb prompt, thereby sidestepping any hoped-for sandboxing. Serving repositories over HTTP(S) is unaffected. We're not currently hardening any subcommands other than 'serve'. If your service exposes other commands to users with arbitrary repository names, it is imperative that you defend against repository names of '--debugger' and anything starting with '--config'. The read-only mode of hg-ssh stopped working because it provided its hook configuration to "hg serve --stdio" via --config parameter. This is banned for security reasons now. This patch switches it to directly call ui.setconfig(). If your custom hosting infrastructure relies on passing --config to "hg serve --stdio", you'll need to find a different way to get that configuration into Mercurial, either by using ui.setconfig() as hg-ssh does in this patch, or by placing an hgrc file someplace where Mercurial will read it. mitrandir@fb.com provided some extra fixes for the dispatch code and for hg-ssh in places that I overlooked.

     1

# extension to emulate invoking 'patch.internalpatch()' at the time

     2

# specified by '[fakepatchtime] fakenow'

     3

     4

from __future__ import absolute_import

     5

     6

from mercurial import (

     7

    extensions,

     8

    patch as patchmod,

     9

    util,

    10

)

    11

    12

def internalpatch(orig, ui, repo, patchobj, strip,

    13

                  prefix='', files=None,

    14

                  eolmode='strict', similarity=0):

    15

    if files is None:

    16

        files = set()

    17

    r = orig(ui, repo, patchobj, strip,

    18

             prefix=prefix, files=files,

    19

             eolmode=eolmode, similarity=similarity)

    20

    21

    fakenow = ui.config('fakepatchtime', 'fakenow')

    22

    if fakenow:

    23

        # parsing 'fakenow' in YYYYmmddHHMM format makes comparison between

    24

        # 'fakenow' value and 'touch -t YYYYmmddHHMM' argument easy

    25

        fakenow = util.parsedate(fakenow, ['%Y%m%d%H%M'])[0]

    26

        for f in files:

    27

            repo.wvfs.utime(f, (fakenow, fakenow))

    28

    29

    return r

    30

    31

def extsetup(ui):

    32

    extensions.wrapfunction(patchmod, 'internalpatch', internalpatch)