match: strengthen visit_children_set invariant, Recursive means "all files" My previous interpretation of "Recursive" was too relaxed: I thought it instructed the caller to do something like this: > you can stop calling `visit_children_set` because you'll need to descend into > every directory recursively, but you should still check every file if it > matches or not Whereas the real instruction seems to be: > I guarantee that everything in this subtree matches, you can stop > querying the matcher for all files and dirs altogether. The evidence to support this: - the test actually passes with the stronger invariant, revealing no exceptions from this rule - the implementation of `visit_children_set` for `DifferenceMatcher` clearly relies on this requirement, so it must hold for that not to lead to bugs.

     1

adding changesets

     2

adding manifests

     3

adding file changes

     4

added 1 changesets with 4 changes to 4 files

     5

new changesets d326ae2d01ee (1 drafts)

     6

4 files updated, 0 files merged, 0 files removed, 0 files unresolved

     7

adding changesets

     8

adding manifests

     9

adding file changes

    10

added 1 changesets with 4 changes to 4 files

    11

new changesets d326ae2d01ee (1 drafts)

    12

4 files updated, 0 files merged, 0 files removed, 0 files unresolved