match: strengthen visit_children_set invariant, Recursive means "all files" My previous interpretation of "Recursive" was too relaxed: I thought it instructed the caller to do something like this: > you can stop calling `visit_children_set` because you'll need to descend into > every directory recursively, but you should still check every file if it > matches or not Whereas the real instruction seems to be: > I guarantee that everything in this subtree matches, you can stop > querying the matcher for all files and dirs altogether. The evidence to support this: - the test actually passes with the stronger invariant, revealing no exceptions from this rule - the implementation of `visit_children_set` for `DifferenceMatcher` clearly relies on this requirement, so it must hold for that not to lead to bugs.

     1

  $ hg init a

     2

  $ cd a

     3

  $ touch a; hg commit -qAm_

     4

  $ hg bookmark $(for i in $($TESTDIR/seq.py 0 20); do echo b$i; done)

     5

  $ hg clone . ../b -q

     6

  $ cd ../b

     7

     8

Checking that when lookup multiple bookmarks in one go, if one of them

     9

fails (thus causing the sshpeer to be stopped), the errors from the

    10

further lookups don't result in tracebacks.

    11

    12

  $ hg pull -r b0 -r nosuchbookmark $(for i in $($TESTDIR/seq.py 1 20); do echo -r b$i; done) ssh://user@dummy/$(pwd)/../a

    13

  pulling from ssh://user@dummy/$TESTTMP/b/../a

    14

  abort: unknown revision 'nosuchbookmark'

    15

  [255]