match: strengthen visit_children_set invariant, Recursive means "all files" My previous interpretation of "Recursive" was too relaxed: I thought it instructed the caller to do something like this: > you can stop calling `visit_children_set` because you'll need to descend into > every directory recursively, but you should still check every file if it > matches or not Whereas the real instruction seems to be: > I guarantee that everything in this subtree matches, you can stop > querying the matcher for all files and dirs altogether. The evidence to support this: - the test actually passes with the stronger invariant, revealing no exceptions from this rule - the implementation of `visit_children_set` for `DifferenceMatcher` clearly relies on this requirement, so it must hold for that not to lead to bugs.

     1

Same with share-safe

     2

     3

  $ echo "[format]"         >> $HGRCPATH

     4

  $ echo "use-share-safe = True" >> $HGRCPATH

     5

     6

  $ cd $TESTTMP

     7

     8

  $ hg init myrepo

     9

  $ cd myrepo

    10

  $ cat > .hg/hgrc <<EOF

    11

  > [extensions]

    12

  > sparse=

    13

  > EOF

    14

    15

  $ echo a > show

    16

  $ echo x > hide

    17

  $ hg ci -Aqm 'initial'

    18

    19

Regression test: checks that this command correctly locks the store

    20

before updating the store [requirements] config.

    21

    22

  $ hg up -q 0

    23

  $ hg debugsparse --include 'hide'