match: strengthen visit_children_set invariant, Recursive means "all files" My previous interpretation of "Recursive" was too relaxed: I thought it instructed the caller to do something like this: > you can stop calling `visit_children_set` because you'll need to descend into > every directory recursively, but you should still check every file if it > matches or not Whereas the real instruction seems to be: > I guarantee that everything in this subtree matches, you can stop > querying the matcher for all files and dirs altogether. The evidence to support this: - the test actually passes with the stronger invariant, revealing no exceptions from this rule - the implementation of `visit_children_set` for `DifferenceMatcher` clearly relies on this requirement, so it must hold for that not to lead to bugs.

     1

https://bz.mercurial-scm.org/842

     2

     3

  $ hg init repo

     4

  $ cd repo

     5

  $ echo foo > a

     6

  $ hg ci -Ama

     7

  adding a

     8

     9

  $ hg up -r0000

    10

  0 files updated, 0 files merged, 1 files removed, 0 files unresolved

    11

    12

  $ echo bar > a

    13

    14

Should issue new head warning:

    15

    16

  $ hg ci -Amb

    17

  adding a

    18

  created new head

    19

    20

  $ hg up -r0000

    21

  0 files updated, 0 files merged, 1 files removed, 0 files unresolved

    22

    23

  $ echo stuffy > a

    24

    25

Should not issue new head warning:

    26

    27

  $ hg ci -q -Amc

    28

    29

  $ hg up -r0000

    30

  0 files updated, 0 files merged, 1 files removed, 0 files unresolved

    31

    32

  $ echo crap > a

    33

  $ hg branch testing

    34

  marked working directory as branch testing

    35

  (branches are permanent and global, did you want a bookmark?)

    36

    37

Should not issue warning:

    38

    39

  $ hg ci -q -Amd

    40