match: strengthen visit_children_set invariant, Recursive means "all files" My previous interpretation of "Recursive" was too relaxed: I thought it instructed the caller to do something like this: > you can stop calling `visit_children_set` because you'll need to descend into > every directory recursively, but you should still check every file if it > matches or not Whereas the real instruction seems to be: > I guarantee that everything in this subtree matches, you can stop > querying the matcher for all files and dirs altogether. The evidence to support this: - the test actually passes with the stronger invariant, revealing no exceptions from this rule - the implementation of `visit_children_set` for `DifferenceMatcher` clearly relies on this requirement, so it must hold for that not to lead to bugs.

     1

import sys

     2

     3

from mercurial import (

     4

    pycompat,

     5

    util,

     6

)

     7

     8

     9

def main(argv):

    10

    enc = util.urlreq.quote(pycompat.sysbytes(argv[1]))

    11

    if pycompat.iswindows:

    12

        fmt = 'file:///%s'

    13

    else:

    14

        fmt = 'file://%s'

    15

    print(fmt % pycompat.sysstr(enc))

    16

    17

    18

if __name__ == '__main__':

    19

    main(sys.argv)