match: strengthen visit_children_set invariant, Recursive means "all files" My previous interpretation of "Recursive" was too relaxed: I thought it instructed the caller to do something like this: > you can stop calling `visit_children_set` because you'll need to descend into > every directory recursively, but you should still check every file if it > matches or not Whereas the real instruction seems to be: > I guarantee that everything in this subtree matches, you can stop > querying the matcher for all files and dirs altogether. The evidence to support this: - the test actually passes with the stronger invariant, revealing no exceptions from this rule - the implementation of `visit_children_set` for `DifferenceMatcher` clearly relies on this requirement, so it must hold for that not to lead to bugs.

     1

#ifndef HG_MPATCH_H

     2

#define HG_MPATCH_H

     3

     4

#define MPATCH_ERR_NO_MEM -3

     5

#define MPATCH_ERR_CANNOT_BE_DECODED -2

     6

#define MPATCH_ERR_INVALID_PATCH -1

     7

     8

struct mpatch_frag {

     9

	int start, end, len;

    10

	const char *data;

    11

};

    12

    13

struct mpatch_flist {

    14

	struct mpatch_frag *base, *head, *tail;

    15

};

    16

    17

int mpatch_decode(const char *bin, ssize_t len, struct mpatch_flist **res);

    18

ssize_t mpatch_calcsize(ssize_t len, struct mpatch_flist *l);

    19

void mpatch_lfree(struct mpatch_flist *a);

    20

int mpatch_apply(char *buf, const char *orig, ssize_t len,

    21

                 struct mpatch_flist *l);

    22

struct mpatch_flist *

    23

mpatch_fold(void *bins, struct mpatch_flist *(*get_next_item)(void *, ssize_t),

    24

            ssize_t start, ssize_t end);

    25

    26

#endif